Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add setupFilesAfterEnv and jest.setTimeout example #8971

Merged
merged 5 commits into from Sep 22, 2019
Merged

docs: Add setupFilesAfterEnv and jest.setTimeout example #8971

merged 5 commits into from Sep 22, 2019

Conversation

Acrontum-Carmichael
Copy link
Contributor

Summary

The current docs did not efficiently explain setupTestFrameworkScriptFile was deprecated nor give a clear example of how to use.

Test plan

n/a as doc changes only

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jeysal
jeysal reviewed Sep 21, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense to have an example there!

docs/JestObjectAPI.md Outdated Show resolved Hide resolved
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jeysal
jeysal approved these changes Sep 22, 2019
View reviewed changes
Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the lint and copied changes to versioned docs, will now merge 👍 Thanks!

@jeysal jeysal changed the title docs: setupFilesAfterEnv arr expansion and updated reference in JestObjectApi docs: Add setupFilesAfterEnv and jest.setTimeout example Sep 22, 2019
@jeysal jeysal merged commit bfb4805 into jestjs:master Sep 22, 2019
@ahnpnl ahnpnl mentioned this pull request Jan 22, 2020
Closed
This was referenced Jan 28, 2020
Open
Open
This was referenced Feb 4, 2020
Open
Open
Open
Open
This was referenced Feb 18, 2020
Open
Open
Open
@Leko Leko mentioned this pull request Feb 25, 2020
Open
This was referenced Mar 3, 2020
Open
Open
This was referenced Mar 10, 2020
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
This was referenced Mar 24, 2020
Open
Open
This was referenced Apr 16, 2020
Open
Open
Merged
Closed
Merged
This was referenced Apr 30, 2020
Closed
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeysal jeysal jeysal approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Acrontum-Carmichael @facebook-github-bot @jeysal