Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --testNamePattern matching against it.concurrent within describe #9090

Merged
merged 3 commits into from Feb 20, 2020

Conversation

dmitri-gb
Copy link
Contributor

@dmitri-gb dmitri-gb commented Oct 24, 2019

Summary

This PR aims to fix an issue with it.concurrent where a test is marked as PASSED without even being invoked when --testNamePattern is used to select the test. This has been reported e.g. in #5071. The issue also manifests every time a single test (defined with it.concurrent) is run in the WebStorm IDE using the "run" gutter icon.

Fixes #5071

Test plan

I included an integration test that demonstrates the issue.

@facebook-github-bot
Copy link
Contributor

Hi dmitri-gb! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-io
Copy link

codecov-io commented Oct 24, 2019

Codecov Report

Merging #9090 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9090   +/-   ##
=======================================
  Coverage   64.71%   64.71%           
=======================================
  Files         277      277           
  Lines       11702    11702           
  Branches     2872     2871    -1     
=======================================
  Hits         7573     7573           
  Misses       3514     3514           
  Partials      615      615
Impacted Files Coverage Δ
packages/jest-jasmine2/src/jasmine/Env.ts 0% <ø> (ø) ⬆️
packages/jest-jasmine2/src/jasmineAsyncInstall.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 164e209...43f0e16. Read the comment docs.

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test.concurrent does not run with testNamePattern when inside describe block
5 participants