Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use half of the available cores when in watchAll mode #9117

Merged

Conversation

brapifra
Copy link
Contributor

Summary

Fixes #9116

Test plan

Added a new condition in the Returns based on the number of cpus test of the packages/jest-config/src/__tests__/getMaxWorkers.test.ts file

@facebook-github-bot
Copy link
Contributor

Hi brapifra! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@brapifra brapifra changed the title Use half of the available CPUs when in watchAll mode Use half of the available cores when in watchAll mode Oct 31, 2019
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you update the changelog as well?

@brapifra
Copy link
Contributor Author

brapifra commented Nov 1, 2019

Done @SimenB 😄

@codecov-io
Copy link

Codecov Report

Merging #9117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9117      +/-   ##
==========================================
+ Coverage   64.73%   64.73%   +<.01%     
==========================================
  Files         277      277              
  Lines       11707    11709       +2     
  Branches     2875     2875              
==========================================
+ Hits         7578     7580       +2     
  Misses       3512     3512              
  Partials      617      617
Impacted Files Coverage Δ
packages/jest-config/src/getMaxWorkers.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed07de2...7daffce. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

watchAll mode uses all available cores
4 participants