Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-utils: add a getter for process.domain #9136

Merged
merged 11 commits into from Nov 11, 2019

Conversation

idan-at
Copy link
Contributor

@idan-at idan-at commented Nov 5, 2019

Fixes #7247

The reason of the change is that in node 12 process.domain is non-enumerable

Fixes jestjs#7247: Explicitly copy domain to new process
@facebook-github-bot
Copy link
Contributor

Hi idan-at! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

Merging #9136 into master will decrease coverage by 0.01%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9136      +/-   ##
==========================================
- Coverage   64.83%   64.82%   -0.02%     
==========================================
  Files         278      278              
  Lines       11732    11736       +4     
  Branches     2882     2884       +2     
==========================================
+ Hits         7607     7608       +1     
- Misses       3508     3510       +2     
- Partials      617      618       +1
Impacted Files Coverage Δ
packages/jest-util/src/createProcessObject.ts 69.38% <25%> (-3.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17c70f6...8168c0e. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be an e2e test rather than unit test as we don't wanna mess with our own global env

globalSetupFile.js Outdated Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Nov 11, 2019

Node 8 is not happy, could you take a look?

@idan-at
Copy link
Contributor Author

idan-at commented Nov 11, 2019

@SimenB thanks for the quick reply!

I'm on it, trying to find a non hacky way for solving it

@idan-at
Copy link
Contributor Author

idan-at commented Nov 11, 2019

@SimenB done :)

@SimenB SimenB merged commit 70546e0 into jestjs:master Nov 11, 2019
@SimenB
Copy link
Member

SimenB commented Nov 11, 2019

Thank you!

mapleeit added a commit to mapleeit/jest that referenced this pull request Nov 24, 2020
Considering we drop support for Node 8, this compromise can be removed.

jestjs#9136
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node process.domain behavior broken when running code using Jest
4 participants