Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add buildDefaultResolverRequire #9194

Merged
merged 2 commits into from Nov 23, 2019
Merged

feat: add buildDefaultResolverRequire #9194

merged 2 commits into from Nov 23, 2019

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 16, 2019

This is a breaking out of buildDefaultResolverRequire from #8829 as requested

@SimenB I've not written tests or add an entry in the changelog as it seemed like a bit of overkill for something that is going to be used in future PRs.

I did a sweep of the codebase, and the only place this could actually be used right now is in jest-core, but that'd require implementing support for the callback parameters 馃し鈥嶁檧

It'll be nice to trim down the transformer PRs a bit :)

@codecov-io
Copy link

codecov-io commented Nov 16, 2019

Codecov Report

Merging #9194 into master will decrease coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9194      +/-   ##
==========================================
- Coverage    65.1%   65.06%   -0.05%     
==========================================
  Files         278      278              
  Lines       11860    11865       +5     
  Branches     2923     2925       +2     
==========================================
- Hits         7722     7720       -2     
- Misses       3511     3517       +6     
- Partials      627      628       +1
Impacted Files Coverage 螖
packages/jest-transform/src/ScriptTransformer.ts 67.82% <0%> (-1.51%) 猬囷笍
packages/expect/src/utils.ts 94.93% <0%> (-1.27%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 77c3cee...57bd1e4. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be exported from packages/jest-transform/src/index.ts. Also needs a changelog entry. It adds a public function, so I think it deserves its own mention

packages/jest-transform/src/ScriptTransformer.ts Outdated Show resolved Hide resolved
@SimenB SimenB changed the title Create buildDefaultResolverRequire function feat: add buildDefaultResolverRequire Nov 23, 2019
@SimenB SimenB merged commit 2c1addd into jestjs:master Nov 23, 2019
@G-Rath G-Rath deleted the implement-buildDefaultResolverRequire-function branch November 24, 2019 00:03
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants