Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Reset isolateModules after failing #9541

Merged
merged 4 commits into from Feb 9, 2020
Merged

fix: Reset isolateModules after failing #9541

merged 4 commits into from Feb 9, 2020

Conversation

doniyor2109
Copy link
Contributor

Fixes #9536

@drew-gross
Copy link

Codecov Report

Merging #9541 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9541   +/-   ##
=======================================
  Coverage   65.03%   65.04%           
=======================================
  Files         283      283           
  Lines       12113    12115    +2     
  Branches     3000     3000           
=======================================
+ Hits         7878     7880    +2     
  Misses       3597     3597           
  Partials      638      638           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9250bc...92be511. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A changelog entry and we should be good to go 🙂

@codecov-io
Copy link

Codecov Report

Merging #9541 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9541      +/-   ##
==========================================
+ Coverage   65.03%   65.04%   +<.01%     
==========================================
  Files         283      283              
  Lines       12113    12114       +1     
  Branches     3000     3000              
==========================================
+ Hits         7878     7879       +1     
  Misses       3597     3597              
  Partials      638      638
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 65.3% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9250bc...20cf9f0. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When an expect call fails inside jest.isolateModules the sandbox doesn't get unloaded
6 participants