Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove getVmContext from node env on older versions of node #9708

Merged
merged 1 commit into from Mar 26, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 26, 2020

Summary

Should silently fix #9538 without people needing to upgrade their version of node

Test plan

I tested with node 10.14.0 and 10.14.2 locally - seems to work correctly

@SimenB SimenB force-pushed the remove-get-vm-context-buggy-node branch from 47e5ecc to acfbd7f Compare March 26, 2020 11:00
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting testEnvironment to node causes jest functions to be undefined
3 participants