Fix coverage reporter for uncovered files without transformers #9724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2020
SimenB
commented
Mar 29, 2020
| * | ||
| * Previous behavior of emitting no map when we can't map back to original source is preserved. | ||
| */ | ||
| sourceMaps: canMapToInput ? 'both' : false, |
There was a problem hiding this comment.
specifically this line that breaks. I can keep everything else and just remove this line (or set it to false) and everything works again. But I thought a full revert makes more sense than a partial one
There was a problem hiding this comment.
Thanks! Revert seems appropriate given how confusing this area is.
Hopefully can re-attempt this one soon.
This reverts commit 03a7877.
SimenB
force-pushed
the
coverage-no-transform
branch
from
c1c53aa
to
45cc554
Compare
This was referenced Apr 25, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The source map for some reason beaks code coverage for uncovered files, as discovered in prettier. This reverts the commit that broke it, and adds a regression test.
Reverts #9460. /cc @mbpreble
Test plan
Regression test added.