Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(jest-types): expose type CacheKeyOptions for getCacheKey #9762

Merged
merged 1 commit into from Apr 3, 2020
Merged

chore(jest-types): expose type CacheKeyOptions for getCacheKey #9762

merged 1 commit into from Apr 3, 2020

Conversation

ahnpnl
Copy link
Contributor

@ahnpnl ahnpnl commented Apr 3, 2020

Summary

Expose type CacheKeyOptions for getCacheKey

Test plan

Green CI

@ahnpnl ahnpnl changed the title chore(jest-types): expose CacheKeyOptions for getCacheKey chore(jest-types): expose type CacheKeyOptions for getCacheKey Apr 3, 2020
@ahnpnl
Copy link
Contributor Author

ahnpnl commented Apr 3, 2020

@SimenB this should be the only type left that ts-jest needs.

SimenB
SimenB approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimenB this should be the only type left that ts-jest needs.

Wonderful!

@SimenB SimenB merged commit 9f7fa46 into jestjs:master Apr 3, 2020
@ahnpnl ahnpnl deleted the expose-cache-key-options branch April 3, 2020 14:11
@ahnpnl ahnpnl mentioned this pull request Apr 3, 2020
Merged
jeysal added a commit to mmkal/jest that referenced this pull request Apr 10, 2020
@jeysal
Merge remote-tracking branch 'upstream/master' into uglier-inline-sna…
1b10dc8 
…pshots

* upstream/master: (225 commits)
  docs: add CLA link to contributing docs (jestjs#9789)
  chore: roll new version of docs
  v25.3.0
  chore: update changelog for release
  chore(jest-types): correct type testRegex for ProjectConfig (jestjs#9780)
  feat(circus): enable writing async test event handlers (jestjs#9397)
  feat: enable all babel syntax plugins (jestjs#9774)
  chore: add helper for getting Jest's config in e2e tests (jestjs#9770)
  feat: pass ESM options to transformers (jestjs#9597)
  chore: replace `any`s with `unknown`s (jestjs#9626)
  feat: pass ESM options to Babel (jestjs#9766)
  chore(website): add copy button the code blocks (jestjs#9750)
  chore: bump istanbul-reports for new uncovered lines design (jestjs#9758)
  chore: correct CHANGELOG.md (jestjs#9763)
  chore(jest-types): expose type `CacheKeyOptions` for `getCacheK… (jestjs#9762)
  docs: Fix simple typo, seperated -> separated (jestjs#9760)
  v25.2.7
  chore: update changelog for release
  fix: drop getters and setters when diffing objects for error (jestjs#9757)
  chore(jest-types): correct return type of shouldRunTestSuite fo… (jestjs#9753)
  ...
This was referenced May 1, 2020
Merged
Closed
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ahnpnl @SimenB @facebook-github-bot