feat: pass ESM options to Babel #9766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Apr 4, 2020
| @@ -17,6 +17,7 @@ | |||
| {"path": "../jest-snapshot"}, | |||
| {"path": "../jest-source-map"}, | |||
| {"path": "../jest-test-result"}, | |||
| {"path": "../jest-transform"}, | |||
There was a problem hiding this comment.
this was missing, sometimes leading to weird type errors
Codecov Report
@@ Coverage Diff @@
## master #9766 +/- ##
=======================================
Coverage 64.88% 64.88%
=======================================
Files 288 288
Lines 12190 12193 +3
Branches 3020 3024 +4
=======================================
+ Hits 7910 7912 +2
- Misses 3639 3640 +1
Partials 641 641
Continue to review full report at Codecov.
|
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Apr 10, 2020
…pshots * upstream/master: (225 commits) docs: add CLA link to contributing docs (jestjs#9789) chore: roll new version of docs v25.3.0 chore: update changelog for release chore(jest-types): correct type testRegex for ProjectConfig (jestjs#9780) feat(circus): enable writing async test event handlers (jestjs#9397) feat: enable all babel syntax plugins (jestjs#9774) chore: add helper for getting Jest's config in e2e tests (jestjs#9770) feat: pass ESM options to transformers (jestjs#9597) chore: replace `any`s with `unknown`s (jestjs#9626) feat: pass ESM options to Babel (jestjs#9766) chore(website): add copy button the code blocks (jestjs#9750) chore: bump istanbul-reports for new uncovered lines design (jestjs#9758) chore: correct CHANGELOG.md (jestjs#9763) chore(jest-types): expose type `CacheKeyOptions` for `getCacheK… (jestjs#9762) docs: Fix simple typo, seperated -> separated (jestjs#9760) v25.2.7 chore: update changelog for release fix: drop getters and setters when diffing objects for error (jestjs#9757) chore(jest-types): correct return type of shouldRunTestSuite fo… (jestjs#9753) ...
This was referenced May 1, 2020
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Extracted from #9597. I don't like the changes to
ScriptTransformerin that PR, but I think the changes tobabel-jestmakes sense.Test plan
Unit tests added. As with #9597, there's no real way of triggering this behavior with real code so not thoroughly tested