Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove warning when mutating require.cache #9946

Merged
merged 3 commits into from May 2, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 2, 2020

Summary

Fixes #9916

Test plan

Green CI

@codecov-io
Copy link

Codecov Report

Merging #9946 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9946      +/-   ##
==========================================
- Coverage   64.24%   64.21%   -0.04%     
==========================================
  Files         292      292              
  Lines       12466    12461       -5     
  Branches     3078     3077       -1     
==========================================
- Hits         8009     8002       -7     
- Misses       3809     3810       +1     
- Partials      648      649       +1     
Impacted Files Coverage Δ
packages/jest-runtime/src/index.ts 57.56% <100.00%> (-0.37%) ⬇️
packages/expect/src/utils.ts 94.96% <0.00%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 649796d...726bea1. Read the comment docs.

@SimenB SimenB merged commit 78bb25a into jestjs:master May 2, 2020
@SimenB SimenB deleted the require-cache-warning branch May 2, 2020 08:09
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spurious 'require.cache' modification is not permitted warnings since 25.5.0
3 participants