chore: rename LolexFakeTimers to ModernFakeTimers #9960
Conversation
| @@ -18,12 +18,13 @@ | |||
| - `[*]` [**BREAKING**] Drop support for Node 8 ([#9423](https://github.com/facebook/jest/pull/9423)) | |||
| - `[*]` Upgrade to chalk@4 ([#9752](https://github.com/facebook/jest/pull/9752)) | |||
| - `[*]` Remove usage of `realpath-native` ([#9952](https://github.com/facebook/jest/pull/9952)) | |||
| - `[jest-runtime]` [**BREAKING**] Remove long-deprecated `require.requireActual` and `require.requireMock` methods ([#9854](https://github.com/facebook/jest/pull/9854)) | |||
There was a problem hiding this comment.
new is on line 25, I just sorted the entries
| @@ -24,7 +21,7 @@ type Timer = { | |||
| class NodeEnvironment implements JestEnvironment { | |||
| context: Context | null; | |||
| fakeTimers: LegacyFakeTimers<Timer> | null; | |||
There was a problem hiding this comment.
could rename this to legacyFakeTimers, not sure it's worth the churn for custom envs, tho?
Codecov Report
@@ Coverage Diff @@
## master #9960 +/- ##
=======================================
Coverage 64.06% 64.06%
=======================================
Files 293 293
Lines 12457 12457
Branches 3067 3069 +2
=======================================
Hits 7981 7981
Misses 3833 3833
Partials 643 643
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Prerequisite for #7776. This was never documented, so not a huge breaking change, it's just a rename of the export from
@jest/fake-timersand of the property on the environments. I've also migrated fromlolexto its new name@sinonjs/fake-timers. Way more boring name, but it's descriptive so whatever 馃槢Test plan
Tests tweaked.