From 956497f9c59d9b953c81a12afe3c0de5e5b2dc43 Mon Sep 17 00:00:00 2001 From: Rob Hogan <2590098+robhogan@users.noreply.github.com> Date: Wed, 21 Sep 2022 07:55:43 -0700 Subject: [PATCH] Fix CircleCI: Node JS 14.17 is now the minimum supported version (#872) Summary: CI tests are failing because [Jest 29](https://github.com/facebook/metro/commit/69607ae715626f11eaecab1e0c05857c85f20662) introduces a dependency on Node `^14.15.0`. This updates our CI setup to Node 14, and in particular Node `^14.17.0`, which is the minimum version of Node 14 supported by ESLint. Also take the opportunity to switch from `circleci` (legacy convenience image) to `cimg` (convenience image), as [recommended](https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034). Pull Request resolved: https://github.com/facebook/metro/pull/872 Test Plan: CircleCI Reviewed By: jacdebug, motiz88 Differential Revision: D39690629 Pulled By: robhogan fbshipit-source-id: 1503c340be524f88b67d82dc354cb8164a06c23c --- circle.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/circle.yml b/circle.yml index d173f07a13..b021257bc4 100644 --- a/circle.yml +++ b/circle.yml @@ -36,7 +36,7 @@ version: 2.1 jobs: run-js-checks: docker: - - image: circleci/node:12 + - image: cimg/node:14.17 steps: - checkout - yarn_install @@ -46,9 +46,9 @@ jobs: command: test-smoke - test-node-12: + test-node-14: docker: - - image: circleci/node:12 + - image: cimg/node:14.17 steps: - checkout - yarn_install @@ -57,7 +57,7 @@ jobs: publish-to-npm: docker: - - image: circleci/node:12 + - image: cimg/node:lts steps: - checkout - yarn_install @@ -71,7 +71,7 @@ workflows: build-and-deploy: jobs: - run-js-checks - - test-node-12 + - test-node-14 - publish-to-npm: filters: branches: