Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated uglify-es dependency #980

Closed
TimJentzsch opened this issue May 15, 2023 · 6 comments
Closed

Replace deprecated uglify-es dependency #980

TimJentzsch opened this issue May 15, 2023 · 6 comments

Comments

@TimJentzsch
Copy link

Do you want to request a feature or report a bug?

"bug", deprecation

What is the current behavior?

During installation, I get the following warning:

npm WARN deprecated uglify-es@3.3.9: support for ECMAScript is superseded by `uglify-js` as of v3.13.0

This is a dependency of metro-minify-uglify:

"uglify-es": "^3.1.9"

If the current behavior is a bug, please provide the steps to reproduce and a minimal repository on GitHub that we can yarn install and yarn test.

Run npm ci on a project using metro with metro-minify-uglify.

What is the expected behavior?

metro does not use any deprecated dependencies.

Please provide your exact Metro configuration and mention your Metro, node, yarn/npm version and operating system.

  • metro@0.73.9
  • node@18.15.0
  • npm@9.6.4
@robhogan robhogan added this to the Next breaking release milestone May 15, 2023
@robhogan
Copy link
Contributor

robhogan commented May 15, 2023

metro-minify-uglify is still installed but not actually used in the default config - metro-minify-terser is now the default.

We kept it in Metro’s dependencies to ease upgrades for anyone who still needed to use it, but it’ll be removed in the next release and folks will need to install it manually from then.

@robhogan
Copy link
Contributor

Closed by #1013

@ahmadsyed
Copy link

Still getting this npx react-native init .

@robhogan
Copy link
Contributor

robhogan commented Jul 10, 2023

That's expected for now - metro-minify-uglify was removed as part of Metro 0.77+ (RN 0.73+, or recent nightlies). The warning is safe to ignore.

@drgnmsr
Copy link

drgnmsr commented Jul 22, 2023

If "the warning is safe to ignore", then why is npx react-native init not installing react-native?

@ElSguidge
Copy link

Issue seemed to occur for me when trying to install React-Native 0.72.0. Try @latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants