{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":9454675,"defaultBranch":"fb-mysql-8.0.32","name":"mysql-5.6","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-04-15T17:54:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717043595.0","currentOid":""},"activityList":{"items":[{"before":"57a1443f172f4ed0683c1b16cce1d02b86cc3b6f","after":"2951169624fbbb3b466057dc10f2e200a430783c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-30T22:59:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Register file on noop\n\nSummary:\nWhen Raft becomes a leader we first append a no-op to the relay log.\nThen we catch up to this no-op before switching to binlog mode.\n\nThe thing is, MySQL underlying logic performs a rotate on this no-op\nevent, but it just doesn't tell Raft about it. If Raft gives up\nswitching to primary, we're left in a state where Raft works off an\nold relay log pointer, which may be invalid.\n\nRegistering the pointer here will cause 2 registers during transtion to primary,\none for the no-op rotate, and another when we actually switch to binlog\nmode. I feel that's fine, especially since it keeps Raft in the know\nabout what MySQL is doing to the logs during a transition.\n\nDifferential Revision: D57941368\n\nfbshipit-source-id: 6b86761b64333a614c14a3f3f3a290c7dce60ce6","shortMessageHtmlLink":"Register file on noop"}},{"before":"f0241a332071c0fb5f25c090ca55b00d98200419","after":"57a1443f172f4ed0683c1b16cce1d02b86cc3b6f","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-30T20:57:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Persist synchronization gtid from P_S.log_status (#1450)\n\nSummary:\nWhen synchronizing engines, get the synchronization coordinates from P_S.log_status table, send from the server plugin to client plugin. Upon receiving, client plugin writes to a file `#clone/#synchronization_coordinates`.\n\n### Approach\n**Protocol**\nAdd a new response type `COM_RES_GTID_V4` and update latest protocol to `CLONE_PROTOCOL_VERSION_V4`.\n\n**Common**\n`synchronize_engines()` call was in `Ha_clone_common_cbk`. But it actually is only called from server or local, not client. So I move this function into the child class(client, server, local, with client implementation is a no-op). The reason I make this change is because, I want to send the gtid from the plugin layer without calling into engine again, and moving `synchronize_engines()` into `Server_Cbk` has the advantage that I can get the server handler, while in `Ha_clone_common_cbk` I cannot.\n\nThe log_status query and set_log_stop steps are moved into a new function `synchronize_logs` under `Ha_clone_common_cbk`.\n\n`populate_synchronization_coordinates` would populate a Key_Values data structure of:\n- gtid(from log_status table)\n- binlog_file\n- binlog_offset\n- gtid(from binlog_file and binlog_offset)\n\nWe want to record both gtid from log_status and from binlog_file/offset because they seem to be out of sync in prod, and need a way to confirm this.\n\n**Client**\n`synchronize_engines()` is a no-op and errors out upon calling.\n\nUpon receiving `COM_RES_GTID_V4`, deserialize the coordinates and persist that in `#clone/#synchronization_coordinates`.\n\n**Server**\n`synchronize_engines()` would call `synchronize_logs` and get the server handle to send the coordinates one by one, utilizing existing helper functions.\n\n**Local**\n`synchronize_engines()` would call `synchronize_logs`, then get the client handle to persist coordinates in `#clone/#synchronization_coordinates`.\n\n**Handle version mismatch**\nIn server, only send coordinate if negotiated version >= V4.\nIn client, #synchronization_coordinates file is cleaned upon start of clone.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1450\n\nTest Plan:\n### MTR\n`local_create_synchronization_coordinates`\n`remote_create_synchronization_coordinates`\n\n### Local clone\nTest on my debug build in devserver after `install plugin clone SONAME 'mysql_clone.so';`:\n1/ `mysql> CLONE LOCAL DATA DIRECTORY = '/home/sunxiayi/mysql/mysql-fork/_build-8.0-Debug/mysql-test/var/tmp/mysqld.1/data_new';`\n2/ Check synchronization coordinate from log_status is the same as in file:\n```\nmysql> select local from performance_schema.log_status;\n+------------------------------------------------------------------------------------------------------------------------------------+\n| local                                                                                                                              |\n+------------------------------------------------------------------------------------------------------------------------------------+\n| {\"gtid_executed\": \"e0e4654f-00fb-11ef-815f-95ead878d1b0:1-3\", \"binary_log_file\": \"master-bin.000001\", \"binary_log_position\": 1019} |\n+------------------------------------------------------------------------------------------------------------------------------------+\n1 row in set (0.01 sec)\n\n2024-03-29T21:35:31.654256Z 13 [Note] [MY-013273] [Clone] Plugin Clone reported: 'Server: w_local: {\"gtid_executed\": \"279dd150-f06c-11ee-abb5-60fac8fc94f1:1-4\", \"binary_log_file\": \"master-bin.000001\", \"binary_log_position\": 1019}.'\n```\n```\n# with binlog\n[sunxiayi@devvm7592.atn0 ~/mysql/mysql-fork/_build-8.0-Debug/mysql-test/var/tmp/mysqld.1/data_new_1/#clone (128f0405)]$ cat '#synchronization_coordinates'\ngtid_from_log_status\n2287bbe2-02be-11ef-aef5-9d0d68e44093:1-2\nbinary_log_file\nmaster-bin.000001\nbinary_log_position\n736\ngtid_from_binlog_file_offset\n2287bbe2-02be-11ef-aef5-9d0d68e44093:1-2\n\n# without binlog\n[sunxiayi@devvm7592.atn0 ~/mysql/mysql-fork/_build-8.0-Debug/mysql-test/var/tmp/mysqld.1/data_new_2/#clone (128f0405)]$ cat '#synchronization_coordinates'\ngtid_from_log_status\n2287bbe2-02be-11ef-aef5-9d0d68e44093:1-2\nbinary_log_file\nmaster-bin.000001\nbinary_log_position\n736\n```\n\n### Remote clone, normal\n1/ Take udb35350.ftw5:3301 as the test server, install my debug build. Take udb12221.atn5:3301 as the client server, install my debug build. Install plugin on both servers.\n2/ On udb12221.atn5:3301, do\n```\n(admin:sys.database@udb12221.atn5 3301) [(none)]> SET GLOBAL clone_valid_donor_list = 'udb35350.ftw5.facebook.com:3301';\n(admin:sys.database@udb12221.atn5 3301) [(none)]> set global clone_enable_compression=\"on\";\n(admin:sys.database@udb12221.atn5 3301) [(none)]> set enable_block_stale_hlc_read=0;\n(admin:sys.database@udb12221.atn5 3301) [(none)]> set allow_noncurrent_db_rw=on;\n(admin:sys.database@udb12221.atn5 3301) [(none)]> CLONE INSTANCE FROM 'dba_scripts:sys.database'@'udb35350.ftw5.facebook.com':3301 IDENTIFIED BY '' REQUIRE SSL;\n```\n3/ Check the new file is written correctly\n4/ Repeat the clone, file is overwritten correctly.\n\n### Remote clone, sev scenario, apply-logs\nIssue a clone command using instance whose mysql.gtid_executed table has hole as donor in the raft world. Also this is copying from secondary to secondary meaning binlog is an apply-logs. Check file on recipient is correct.\n\n### Remote clone, donor and client version mismatch\nOnly update recipient. Clone finishes, file is not there.\n```\n[root@udb12221.atn5 /data/mysql/3304/#clone]# ls\n'#old_files'  '#replace_files'  '#status_fix'  '#view_progress'  '#view_status'\n```\nOnly update donor. Clone finishes, file is not there.\n```\n[root@udb12221.atn5 /data/mysql/3305/#clone]# ls\n'#old_files'  '#replace_files'  '#status_fix'  '#view_progress'  '#view_status'\n```\nUpdate both and do a successful clone. Then only update client. File is not there.\n\nDifferential Revision: D57444990\n\nfbshipit-source-id: eac4accab4c187744765cfa9b352da68c25c5f81","shortMessageHtmlLink":"Persist synchronization gtid from P_S.log_status (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2270453971\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1450\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1450/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1450\">#1450</a>)"}},{"before":null,"after":"8cd5661416752317c3144258437df9ae51bf51a2","ref":"refs/heads/fbcode-mysql-8.0.32","pushedAt":"2024-05-30T04:33:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"Initial commit on orphan branch","shortMessageHtmlLink":"Initial commit on orphan branch"}},{"before":"a902c44fbfec7cb2cfe444d8c4960259d9a4798c","after":"f0241a332071c0fb5f25c090ca55b00d98200419","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-29T15:40:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix valgrind conditional jump or move depends on uninitialised value in Rdb_cmd_srv_status\n\nSummary:\nPrzemyslaw Skibinski <przemyslaw.skibinski@percona.com> reported this valgrind warning\n\n```\n==2587827== Thread 47 connection:\n==2587827== Conditional jump or move depends on uninitialised value(s)\n==2587827==    at 0x717FD9C: unsigned int std::__detail::__to_chars_len<unsigned int>(unsigned int, int) (charconv.h:67)\n==2587827==    by 0x72826BB: std::__cxx11::to_string(unsigned int) (basic_string.h:4170)\n==2587827==    by 0x9653F13: myrocks::Rdb_cmd_srv_status::message[abi:cxx11]() const (rdb_cmd_srv_helper.h:56)\n==2587827==    by 0x9651946: myrocks::(anonymous namespace)::Rdb_vector_index_ivf::setup(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, myrocks::Rdb_cmd_srv_helper&) (rdb_vector_db.cc:456)\n==2587827==    by 0x9652D7C: myrocks::create_vector_index(myrocks::Rdb_cmd_srv_helper&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, FB_vector_index_config, std::shared_ptr<rocksdb::ColumnFamilyHandle>, unsigned int, std::unique_ptr<myrocks::Rdb_vector_index, std::default_delete<myrocks::Rdb_vector_index> >&) (rdb_vector_db.cc:653)\n```\n\nDifferential Revision: D57873682\n\nfbshipit-source-id: df2d26552f978b6c5f3ede8b0c5b4b5c832c34b7","shortMessageHtmlLink":"fix valgrind conditional jump or move depends on uninitialised value …"}},{"before":"b23d301518d834aa91aa326ded5aa1c31ce2fabe","after":"a902c44fbfec7cb2cfe444d8c4960259d9a4798c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-29T01:37:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add thd API to get server hostname\n\nSummary: Expose server hostname (specifically `glob_hostname_ptr` global variable). This value uses the local hostname by default for BM and is configured to use TW FQDN in TW.\n\nDifferential Revision: D57644335\n\nfbshipit-source-id: 6f02020f9c98bc0017a7096c1ae6ce6d00dd6004","shortMessageHtmlLink":"Add thd API to get server hostname"}},{"before":"d8246d2cddbad65d430bbdb10997cf072cb17dbc","after":"b23d301518d834aa91aa326ded5aa1c31ce2fabe","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-29T01:21:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix for contrun MTR failures in sql_wsenv suite\n\nSummary:\nFix for errors like the following seen in `mysql-80-contrun-fb-mysql-8-0-32-asan-sql_wsenv-withasyncclient`:\n\nP1377385722\n\nDifferential Revision: D57871589\n\nfbshipit-source-id: df836d18b819d06dd922890c8a2c6adcb3ea36b6","shortMessageHtmlLink":"Fix for contrun MTR failures in sql_wsenv suite"}},{"before":"49b37dfe6a0e3be1543d4f534dc64171a39f3c8e","after":"d8246d2cddbad65d430bbdb10997cf072cb17dbc","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-24T16:59:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"consolidate vectordb write path for string pk columns\n\nSummary:\nwhen pk contains string(char/varchar) columns, the SK rocksdb value can contain original string column value. This change takes account of this in vector index read path to ignore bytes that are after the vector codes.\n\nSquash with D57029524\n\nDifferential Revision: D57521085\n\nfbshipit-source-id: 76804e6516cf949724047e95e074e2da7f87e3de","shortMessageHtmlLink":"consolidate vectordb write path for string pk columns"}},{"before":"b4894b05143cacb5040759d6add30c574c707f91","after":"49b37dfe6a0e3be1543d4f534dc64171a39f3c8e","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-24T06:10:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add wait event for create/drop tables flush\n\nSummary: Similar to notifying thread scheduler of wait before performing a fsync in mysys, adding a thd wait event while creating/deleting a table.\n\nDifferential Revision: D57388930\n\nfbshipit-source-id: 1b5ae2fa709fe945ce7bc5086c5a53095e3200b5","shortMessageHtmlLink":"Add wait event for create/drop tables flush"}},{"before":"a4eb4008fa6ec18ba68ecf80c60d6e867c583f1c","after":"b4894b05143cacb5040759d6add30c574c707f91","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-22T00:57:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use after free during ddse upgrade and index stats thread\n\nSummary:\nDuring DDSE upgrade, the call Rdb_ddl_manager::reset_map() will clean ddl map(table name -> table def) and re-create ddl map but it forgot to hold the RW lock. Another thread(such as index stats thread) hit a race condition, such as\n- index stats thread:  fetch table def while hold write lock\n- ddse upgrade thread: clean ddl map\n- index stats thread: try to write data into freed table def while hold write lock\n\nChanges:\n- hold write lock during Rdb_ddl_manager::reset_map() to avoid race condition.\n- skip destroy rw lock during reset_map. destroy rw lock should occurs during shutdown\n- during popular\n\nDifferential Revision: D57464439\n\nfbshipit-source-id: 542dd0fe7cc8ba9a43a7fa73b61102c0de51abeb","shortMessageHtmlLink":"Use after free during ddse upgrade and index stats thread"}},{"before":"ddf945fdfb522363e8b0de5cda7d76bcc700301c","after":"a4eb4008fa6ec18ba68ecf80c60d6e867c583f1c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-21T17:01:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add MTR test for early demotion\n\nSummary:\nThis diff was originally a fix to an ASAN issue, and this MTR test was an\nattempt to trip it. But we found a bigger problem with the Raft demotion\nprocess and made a more wholistic fix to Raft that avoid both problems.\nI still want to get the MTR test in though.\n\nDifferential Revision: D56424620\n\nfbshipit-source-id: 4705f575f4ed1c25faffc5edd3d4002d3d6ad048","shortMessageHtmlLink":"Add MTR test for early demotion"}},{"before":"86f937efd936caf3b3f45437668c96a9210076d4","after":"ddf945fdfb522363e8b0de5cda7d76bcc700301c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-21T02:59:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make mysqlx optional for tests\n\nSummary:\nSome builds might not include mysqlx, but these tests fail trying to\nspecifying --mysqlx. Change to loose-mysqlx to allow the test to run\neven if mysqlx is not present.\n\nSquash with D57513263\n\nDifferential Revision: D57586171\n\nfbshipit-source-id: 408c5bfbade76f7daf297ec6f02b78ea16ef24d8","shortMessageHtmlLink":"Make mysqlx optional for tests"}},{"before":"e4ec872f78900081b7104bbb2a739b7241cb0060","after":"86f937efd936caf3b3f45437668c96a9210076d4","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-20T19:04:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Skip checking warnings for thread_stack adjustment\n\nSummary:\nThe minimum thread_stack size gets adjusted for asan builds,\nso ignore the warnings reported about thread_stack adjustments.\n\nDifferential Revision: D57577655\n\nfbshipit-source-id: 8a28fb48876741154e1631dca125d48550123cc6","shortMessageHtmlLink":"Skip checking warnings for thread_stack adjustment"}},{"before":"0192da17cebffe75bd63aeb9c3dcfb0ec533b1d0","after":"e4ec872f78900081b7104bbb2a739b7241cb0060","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-20T17:41:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix memory_free macro\n\nSummary:\nMEM_FREELIKE_BLOCK should only have two arguments.\n\nSquash with D56051395\n\nDifferential Revision: D57572886\n\nfbshipit-source-id: 4bbda8eddbf5ae5bf334d526984d8674ff0e50a1","shortMessageHtmlLink":"Fix memory_free macro"}},{"before":"565d4dd8ad4ce3eab1d091eee9fea33d1907c84c","after":"0192da17cebffe75bd63aeb9c3dcfb0ec533b1d0","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-20T17:21:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Disable binlog for bulk_load_unsorted MTRs\n\nSummary: When binlog is enabled, bulk loading will take much longer time to execute these load statement and cause MTR timeout.\n\nDifferential Revision: D57540704\n\nfbshipit-source-id: 68e231ea523d06307af0ffd62c548b4e05274ccd","shortMessageHtmlLink":"Disable binlog for bulk_load_unsorted MTRs"}},{"before":"4cea1e5015c413c30cfbde422ca60c8e8a0d3ffa","after":"565d4dd8ad4ce3eab1d091eee9fea33d1907c84c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-20T17:11:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"record rocksdb.optimizer_force_index_rewrite\n\nSummary:\n\"[Bypass RPC] Return error if range queries don't include LIMIT clause\" cause MTR rocksdb.optimizer_force_index_rewrite failure.\n\nsquash: ec07dc87e04\n\nDifferential Revision: D57520705\n\nfbshipit-source-id: 4f33f894e3dd222b52ae96260dfbfbf1e8fd857e","shortMessageHtmlLink":"record rocksdb.optimizer_force_index_rewrite"}},{"before":"61bba3c452ab4b36b8eef16aa0eacbc5bd6eba10","after":"4cea1e5015c413c30cfbde422ca60c8e8a0d3ffa","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-20T17:00:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"record rocksdb.sys_tables_mysqlcheck\n\nSummary:\nPrevious change \"update sys.sys_config table for rocksdb DDSE\" forgot to record rocksdb.sys_tables_mysqlcheck\n\nsquash: 47f579d568b\n\nDifferential Revision: D57517954\n\nfbshipit-source-id: 5725eecbcb620987ec952b1ee521b64d846e99ea","shortMessageHtmlLink":"record rocksdb.sys_tables_mysqlcheck"}},{"before":"a930da0e5a6e94d0c0187ea0685561cf19a500a7","after":"61bba3c452ab4b36b8eef16aa0eacbc5bd6eba10","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T22:04:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update sys.sys_config table for rocksdb DDSE (#1455)\n\nSummary:\nCurrently there are few tables still running INNDOB. and sys.sys_config table is one of them. although sys.sys_config table doesn't belong to DD table or SYSTEM TABLE, also convert this table into RocksDB table\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1455\n\nDifferential Revision: D57264957\n\nfbshipit-source-id: 47f579d568bccb522902675808b294c1a77d3f75","shortMessageHtmlLink":"update sys.sys_config table for rocksdb DDSE (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2293817563\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1455\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1455/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1455\">#1455</a>)"}},{"before":"03b744a26bf360b4c9fcd9ee7d906580d18aadea","after":"a930da0e5a6e94d0c0187ea0685561cf19a500a7","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T20:45:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Merge all the no-op MyRocks system variable update functions (#1454)\n\nSummary:\nCode removal, they differed only by their names.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1454\n\nDifferential Revision: D57355151\n\nfbshipit-source-id: d3432152d2b85a762dc9a0660e2d3ff5e73e9769","shortMessageHtmlLink":"Merge all the no-op MyRocks system variable update functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2289169573\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1454\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1454/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1454\">#1454</a>)"}},{"before":"0b48403fd65606732b503fa2aa9c0bb1d35b4411","after":"03b744a26bf360b4c9fcd9ee7d906580d18aadea","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T17:47:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove Rdb_transaction::m_is_tx_failed field (#1453)\n\nSummary:\nIts sole purpose was to handle rollbacks of single-statement autocommit\ntransactions: first, rocksdb_rollback rolled back the statement itself, set the\nflag, and then ha_rocksdb::external_lock used the flag to roll back the whole\ntransaction.\n\nSimplify this by rolling back the whole transaction in rocksdb_rollback, and\nletting ha_rocksdb::external_lock to always call commit, which DTRT on\nrolled-back transactions too.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1453\n\nDifferential Revision: D57113570\n\nfbshipit-source-id: 3566424608fc9453767b6816729ac688e4df628a","shortMessageHtmlLink":"Remove Rdb_transaction::m_is_tx_failed field (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2282548431\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/mysql-5.6/issues/1453\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/mysql-5.6/pull/1453/hovercard\" href=\"https://github.com/facebook/mysql-5.6/pull/1453\">#1453</a>)"}},{"before":"329588bdd15e6ed0b247259f6697db43e0b376bd","after":"0b48403fd65606732b503fa2aa9c0bb1d35b4411","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T13:25:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Return error if range queries don't include LIMIT clause\n\nSummary:\nWe expect by design that all bypass rpc range query should have limit clause.\n(Note that bypass rpc doesn't support streaming result.)\nLet's return error if bypass rpc range query doesn't include limit clause.\n\nDifferential Revision: D57333989\n\nfbshipit-source-id: ec07dc87e04ce9c98ba8148785b69b382c663a79","shortMessageHtmlLink":"Return error if range queries don't include LIMIT clause"}},{"before":"769db5bbabbc1df31d0be21f4d9af2799b3aac57","after":"329588bdd15e6ed0b247259f6697db43e0b376bd","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-17T01:24:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix rocksdb.singledelete by exclude system cf table stats in the test\n\nSummary:\nrocksdb.singledelete has been unstable because the stats it relies on getting updated by none user tables (DD tables when DDSE is rocksdb).\n- introduce a variable to skip collecting stats for system cf which DD tables are in\n- set the variable in the test\n- remove previous fix attempts in the test\n\nDifferential Revision: D57424255\n\nfbshipit-source-id: cf58823c339dd68b45309fa417d63adbc437603c","shortMessageHtmlLink":"fix rocksdb.singledelete by exclude system cf table stats in the test"}},{"before":"347b71f5dcb60fbdbecf05e19da688479e70c06a","after":"769db5bbabbc1df31d0be21f4d9af2799b3aac57","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-16T00:17:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Do not hold index lock during network write for 'show binary|raft logs'\n\nSummary:\nCurrently, show binary|raft logs holds index lock while sending information to clients. If the client is stuck, index lock will be held for an extended period time, which will block flush and subsequence writes.\n\nThe proper fix is to cache binary log information, release index lock, then send the information to client.\n\nBelow is an easy repro\nStep 1\n```\nmysql --no-defaults -S /home/chili/mysql/mysql80-fork/_build-8.0-Debug/mysql-test/var/tmp/mysqld.1.sock -u root -D test  -e \"show binary logs with gtid\" --quick | sleep 100\n```\nStep 2\n```\nflush binary log;\n```\nStep 3\n```\nmysql> insert into t values(0);\nQuery OK, 1 row affected (44.28 sec)\n```\n\nDifferential Revision: D57355780\n\nfbshipit-source-id: 96fac64a2536293969488ec2154978f2444ec35f","shortMessageHtmlLink":"Do not hold index lock during network write for 'show binary|raft logs'"}},{"before":"9794eb5b479c87cde267b1b453e90d3894626e20","after":"347b71f5dcb60fbdbecf05e19da688479e70c06a","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-15T04:37:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Avoid aborting server when purge_logs() clashes with rli_relay_log_raft_reset()\n\nSummary:\nWithin purge_logs(), after we purge binlogs, it needs to update the binlog's index file. It does this in a crashproof manner within move_crash_safe_index_file_to_index_file() which makes a copy of the index file, modifies it, deletes original index file and renames copied index file in place of the original index file. We abort the server when the rename fails. The rename fails because rli_relay_log_raft_reset() can be running, which restores the index file.\n\nTo avoid this, rli_relay_log_raft_reset() should acquire the global mysql_bin_log's index lock.\n\nSince rli_relay_log_raft_reset() is called when we transition from primary to secondary, I feel it is OK to take a hit on grabbing the index lock.\n\nDifferential Revision: D57198631\n\nfbshipit-source-id: 88a08f1658b736fcf4af41e2c215e858f1d1d9b3","shortMessageHtmlLink":"Avoid aborting server when purge_logs() clashes with rli_relay_log_ra…"}},{"before":"543fc1a32fcfb39a06b4a9ee10117e5bfd18e71c","after":"9794eb5b479c87cde267b1b453e90d3894626e20","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-13T23:55:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"consolidate vectordb write path with sk write\n\nSummary: consolidate vectordb write path to use the same flow as other SKs\n\nDifferential Revision: D57029524\n\nfbshipit-source-id: 5290dd9d3f9ae5a54709c874accf23aea53c33e1","shortMessageHtmlLink":"consolidate vectordb write path with sk write"}},{"before":"8826b9b444c886f6d1e277a025b8131025bd5f87","after":null,"ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-13T17:21:53.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hermanlee","name":"Herman Lee","path":"/hermanlee","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6656176?s=80&v=4"}},{"before":"3a47b3d52036cb3f69ea8159e4e8abfea0726b4a","after":null,"ref":"refs/heads/fbcode-sync-test-8.0.32","pushedAt":"2024-05-13T17:21:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"hermanlee","name":"Herman Lee","path":"/hermanlee","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6656176?s=80&v=4"}},{"before":"0798f2a4fe665b9c04a5cf25dd0c8624f79beeb1","after":"543fc1a32fcfb39a06b4a9ee10117e5bfd18e71c","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-13T16:11:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix async memory references\n\nSummary:\nAsync structures could be freed by calls to end_server. Subsequent reset\ncalls were referencing freed memory, so validate the pointer before\nreferencing the memory.\n\nDifferential Revision: D57280022\n\nfbshipit-source-id: 76110822445377f2c27cf619c9c17cbba9a439c7","shortMessageHtmlLink":"Fix async memory references"}},{"before":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","after":"8826b9b444c886f6d1e277a025b8131025bd5f87","ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-11T20:32:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"fbshipit-source-id: 0ff08e4ca8f5","shortMessageHtmlLink":"fbshipit-source-id: 0ff08e4ca8f5"}},{"before":null,"after":"bae466c2ab791209a4a06d0e6a95395ab11b86c2","ref":"refs/heads/fbcode-sync-test2-8.0.32","pushedAt":"2024-05-11T20:25:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alphaxiaolin","name":null,"path":"/alphaxiaolin","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/154366329?s=80&v=4"},"commit":{"message":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to default_dd_system_storage_engine\n\nSummary:\nTwo PRs https://github.com/facebook/mysql-5.6/pull/1396 and https://github.com/facebook/mysql-5.6/pull/1394 were merged at the same time, whereas the second one to go in needed a rebase.\n\nPull Request resolved: https://github.com/facebook/mysql-5.6/pull/1402\nGitHub Author: Laurynas Biveinis <laurynas.biveinis@gmail.com>\n\nTest Plan: CI\n\nReviewers: herman, #mysql_eng\n\nReviewed By: herman\n\nDifferential Revision: https://phabricator.intern.facebook.com/D51815181","shortMessageHtmlLink":"[mysql-5.6][PR] Convert newly-added default_dd_storage_engine uses to…"}},{"before":"d993fa45c8bc8a0e6e790a0c8d6b8e564ce7dbbf","after":"0798f2a4fe665b9c04a5cf25dd0c8624f79beeb1","ref":"refs/heads/fb-mysql-8.0.32","pushedAt":"2024-05-10T22:49:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix debug assertion in net_write_command_nonblocking()\n\nSummary:\nThe client application calls mysql_close() to shutdown connections.\nmysql_close() attempts to send a COM_QUIT during this process regardless\nof the current state of the connection.\n\nIn debug mode, this trips an assertion in net_write_command_nonblocking\nif the async connection was still actively waiting in the read state for\ndata from the server.\n\nSince it's expected for the async cleanup to send out COM_QUIT during\nshutdown, and since shutdown can happen at any point in time when the\nclient times out, fix the assert to check the command.\n\nDifferential Revision: D57231183\n\nfbshipit-source-id: 1903e021ce7c65cd3cbd4ed179b68731830db9bf","shortMessageHtmlLink":"Fix debug assertion in net_write_command_nonblocking()"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWHzz6AA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/mysql-5.6"}