Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Highlight updates issue redux #1354

Closed
BartlomiejLewandowski opened this issue Jun 16, 2019 · 2 comments
Closed

Highlight updates issue redux #1354

BartlomiejLewandowski opened this issue Jun 16, 2019 · 2 comments

Comments

@BartlomiejLewandowski
Copy link

Apologies if this is a false issue, it looks a bit similar to
#1023.

I have an app which uses redux to publish state changes. It seems that all my connected components are highlighted to show they are being updated via the highlight updates feature.

This would make sense, so I've run the React Profiler to show me what has actually changed. I've then fixed a single component, which after the changes no longer shows rerenders in the Profiler view, but the updates are still being shown in the UI.

I've uploaded a video to show the error:
https://drive.google.com/file/d/1hR-oaGQJRNQ3sP11SpZUUbQ6ALVoOorm/view?usp=sharing

When clicking I send a redux event that changes the state, we can see that all of the connected components rerender. The profiler shows a different thing though, both for the Component and the wrapped component with connect.

@BarthesSimpson
Copy link

#1290

@bvaughn
Copy link
Contributor

bvaughn commented Aug 19, 2019

React DevTools has been rewritten and recently launched a new version 4 UI. The source code for this rewrite was done in a separate repository and now lives in the main React repo (github.com/facebook/react).

Because version 4 was a total rewrite, and all issues in this repository are related to the old version 3 of the extension, I am closing all issues in this repository. If you can still reproduce this issue, or believe this feature request is still relevant, please open a new issue in the React repo: https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools

@bvaughn bvaughn closed this as completed Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants