Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react-native
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.62.1
Choose a base ref
...
head repository: facebook/react-native
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.62.2
Choose a head ref
  • 9 commits
  • 20 files changed
  • 7 contributors

Commits on Apr 3, 2020

  1. Copy the full SHA
    a049130 View commit details

Commits on Apr 7, 2020

  1. Merge pull request #28520 from thymikee/fix/flow-types

    [General] [Fixed] Flow errors from YellowBox and BubblingEventHandler
    alloy authored Apr 7, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8e705b7 View commit details

Commits on Apr 8, 2020

  1. Fix mock for TextInput (#28332)

    Summary:
    This PR adds the `isFocused` method to the mock of the TextInput component. My understanding some of the latest changes on the TextInput to make it use a forwardRef change the way this method is mock giving an error when trying to use in on a mock.
    The change suggested here fixes the issue.
    
    ## Changelog
    
    [JavaScript] [Fixed] - Fix the mock for TextInput to support the `isFocused` method
    Pull Request resolved: #28332
    
    Reviewed By: cpojer
    
    Differential Revision: D20538044
    
    Pulled By: TheSavior
    
    fbshipit-source-id: be734af105ab62ffdf9ed4017bd70845e207f8cd
    SergioEstevao authored and alloy committed Apr 8, 2020
    Copy the full SHA
    9a00cec View commit details
  2. Fix crash when enabling Performance Monitor on iOS 13.4 (#28512)

    Summary:
    This PR fixes a crash when opening the Performance Monitor on iOS 13.4.
    Detailed info: #28414
    
    ## Changelog
    
    `[iOS] [Fixed] - Fix crash when enabling Performance Monitor on iOS 13.4`
    
    ## How
    
    This PR prevents the JavaScriptCore option from being set altogether.
    This ensures that the performance monitor keeps working, but on iOS 13.4 and higher, it will no longer crash trying to show the GC usage.
    Pull Request resolved: #28512
    
    Test Plan:
    Tested on iOS 13.4 (simulator):
    
    ![image](https://user-images.githubusercontent.com/6184593/77903803-c6370c00-7283-11ea-8b71-b6b6546c82f6.png)
    
    Tested on iOS 13.1 (simulator)
    
    ![image](https://user-images.githubusercontent.com/6184593/77903499-41e48900-7283-11ea-9d14-83f67a3b7b77.png)
    
    - Verified that the `setOption` was called, but the Performance Monitor didn't show any GC usage regardless.
    - Identical PR expo#21 has been shipped and tested in Expo Client 37
    
    Fixes #28414
    
    Reviewed By: PeteTheHeat
    
    Differential Revision: D20851131
    
    Pulled By: TheSavior
    
    fbshipit-source-id: ff96301036e8487db59f95947bbe6841fe230e1e
    IjzerenHein authored and alloy committed Apr 8, 2020
    Copy the full SHA
    6b6877d View commit details
  3. Move DebugEnvironment helper to open source

    Summary:
    This is an internal only module that we use to detect whether we are in async debugging mode.
    
    Changelog: [Internal]
    
    Reviewed By: yungsters
    
    Differential Revision: D20879780
    
    fbshipit-source-id: 5915f4e1c54a3fda0cf607c77f463120264fdbc4
    elicwhite authored and alloy committed Apr 8, 2020
    Copy the full SHA
    6e530d9 View commit details
  4. Fix Appearance module when using Chrome Debugger

    Summary:
    The appearance module uses sync native module methods which doesn't work with the chrome debugger. This broke in 0.62: #26705
    
    This fix makes the appearance module return 'light' when using the chrome debugger.
    
    Changelog: [Fixed] Appearance `getColorScheme` no longer breaks the debugger
    
    Reviewed By: yungsters
    
    Differential Revision: D20879779
    
    fbshipit-source-id: ad49c66226096433bc9f270e004ad4a6f54fa8c2
    elicwhite authored and alloy committed Apr 8, 2020
    1
    Copy the full SHA
    4fd9c9d View commit details
  5. Exclude all FlipperKit transitive dependencies from iOS Release builds (

    #28504)
    
    Summary:
    The `:configuration` option from `pod` only affects the specified pod and not its dependencies [1]. Therefore in order to avoid all transitive dependencies being linked in the resulting Release IPA we need to list them in the `Podfile`.
    
    Note that this will still build Flipper's pods when doing a Release, but it won't link it in the resulting IPA.
    
    [1] https://guides.cocoapods.org/syntax/podfile.html#pod
    
    Fixes react-native-community/upgrade-support#28
    Related CocoaPods/CocoaPods#9658
    
    * [iOS] [Fixed] - Exclude Flipper from iOS Release builds
    Pull Request resolved: #28504
    
    Test Plan:
    Create a new React Native 0.62 project, run `pod install`, then diff:
    ```
    ProjectName/ios/Pods/Target Support Files/Pods-ProjectName/Pods-ProjectName.debug.xcconfig`
    ```
    and
    ```
    ProjectName/ios/Pods/Target Support Files/Pods-ProjectName/Pods-ProjectName.relaese.xcconfig
    ```
    
    ![image](https://user-images.githubusercontent.com/855995/78337679-a3fa0280-7591-11ea-8142-6f82cbc6be58.png)
    
    Reviewed By: passy
    
    Differential Revision: D20894406
    
    Pulled By: priteshrnandgaonkar
    
    fbshipit-source-id: 680780f0f5a85fd8423b85a271a499bd12f06d00
    Javier Cuevas authored and alloy committed Apr 8, 2020
    Copy the full SHA
    8858d87 View commit details
  6. Make Vibration.vibrate compatible with TurboModules (#27951)

    Summary:
    This PR fixes a compatibility issue with the Vibration module and TurboModules.
    The TurboModules spec doesn't allow nullable arguments of type Number, causing the following problem:
    
    ![IMG_3758](https://user-images.githubusercontent.com/1247834/73803879-10be6f80-4790-11ea-92d4-a008f0007681.PNG)
    
    [iOS] [Fixed] - Make Vibration library compatible with TurboModules.
    Pull Request resolved: #27951
    
    Test Plan:
    Just submitted a PR to my own app to fix the issue [here](rainbow-me/rainbow#340)
    
    The problem should be reproducible on RNTester due to this line: https://github.com/facebook/react-native/blob/91f139b94118fe8db29728ea8ad855fc4a13f743/RNTester/js/examples/Vibration/VibrationExample.js#L66  and should be working on this branch.
    
    Reviewed By: TheSavior
    
    Differential Revision: D19761064
    
    Pulled By: hramos
    
    fbshipit-source-id: 84f6b62a2734cc09d450e906b5866d4e9ce61124
    brunobar79 authored and alloy committed Apr 8, 2020
    Copy the full SHA
    f89c509 View commit details
  7. [0.62.2] Bump version numbers

    alloy committed Apr 8, 2020
    Copy the full SHA
    b9944e5 View commit details
Loading