From 72ff92a5d8fe6d2e3c86d37042e3db834d5a9977 Mon Sep 17 00:00:00 2001 From: hdineen Date: Fri, 28 Feb 2020 11:46:05 -0500 Subject: [PATCH] Adding a test for the "Unknown" branch when `getComponentName()` returns a falsy value. The error message in this case not the most descriptive but seems consistent with the `getComponentName(type) || 'Unknown'` pattern seen in multiple places in this code base. --- .../src/__tests__/ReactTestRenderer-test.internal.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js b/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js index d9c8d5b1c520..06f7131f2bd5 100644 --- a/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js +++ b/packages/react-test-renderer/src/__tests__/ReactTestRenderer-test.internal.js @@ -1022,4 +1022,14 @@ describe('ReactTestRenderer', () => { expect(Scheduler).toFlushWithoutYielding(); ReactTestRenderer.create(); }); + + it('calling findByType() with an invalid component will fall back to "Unknown" for component name', () => { + const App = () => null; + const renderer = ReactTestRenderer.create(); + const NonComponent = {}; + + expect(() => { + renderer.root.findByType(NonComponent); + }).toThrowError(`No instances found with node type: "Unknown"`); + }); });