From 96203240d3de3c290f3d6013a8cbcc7b38dc1740 Mon Sep 17 00:00:00 2001 From: Nicolas Gallagher Date: Sat, 18 Apr 2020 15:40:13 -0700 Subject: [PATCH] ReactDOM: remove unstable-native-dependencies bundle (#18483) This is only used by react-native-web and will be replaced by a user-space implementation. See: https://github.com/necolas/react-native-web/issues/1568 --- .../ResponderEventPlugin-test.internal.js | 5 ++- .../npm/unstable-native-dependencies.js | 7 ---- packages/react-dom/package.json | 1 - packages/react-dom/src/client/ReactDOM.js | 4 +-- .../src/test-utils/ReactTestUtils.js | 3 +- .../src/test-utils/ReactTestUtilsAct.js | 3 +- .../ReactDOMUnstableNativeDependencies.js | 32 ------------------- .../react-dom/unstable-native-dependencies.js | 10 ------ scripts/rollup/bundles.js | 9 ------ 9 files changed, 6 insertions(+), 68 deletions(-) delete mode 100644 packages/react-dom/npm/unstable-native-dependencies.js delete mode 100644 packages/react-dom/src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies.js delete mode 100644 packages/react-dom/unstable-native-dependencies.js diff --git a/packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js b/packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js index 8234f6144e6d..6f1acf879a1c 100644 --- a/packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js +++ b/packages/legacy-events/__tests__/ResponderEventPlugin-test.internal.js @@ -404,11 +404,10 @@ describe('ResponderEventPlugin', () => { beforeEach(() => { jest.resetModules(); - const ReactDOMUnstableNativeDependencies = require('react-dom/unstable-native-dependencies'); EventBatching = require('legacy-events/EventBatching'); EventPluginUtils = require('legacy-events/EventPluginUtils'); - ResponderEventPlugin = - ReactDOMUnstableNativeDependencies.ResponderEventPlugin; + ResponderEventPlugin = require('legacy-events/ResponderEventPlugin') + .default; deleteAllListeners(GRANDPARENT_INST); deleteAllListeners(PARENT_INST); diff --git a/packages/react-dom/npm/unstable-native-dependencies.js b/packages/react-dom/npm/unstable-native-dependencies.js deleted file mode 100644 index 6a498a3686e6..000000000000 --- a/packages/react-dom/npm/unstable-native-dependencies.js +++ /dev/null @@ -1,7 +0,0 @@ -'use strict'; - -if (process.env.NODE_ENV === 'production') { - module.exports = require('./cjs/react-dom-unstable-native-dependencies.production.min.js'); -} else { - module.exports = require('./cjs/react-dom-unstable-native-dependencies.development.js'); -} diff --git a/packages/react-dom/package.json b/packages/react-dom/package.json index 1fb6e427947e..a251967e3c63 100644 --- a/packages/react-dom/package.json +++ b/packages/react-dom/package.json @@ -38,7 +38,6 @@ "unstable-fizz.js", "unstable-fizz.browser.js", "unstable-fizz.node.js", - "unstable-native-dependencies.js", "cjs/", "umd/" ], diff --git a/packages/react-dom/src/client/ReactDOM.js b/packages/react-dom/src/client/ReactDOM.js index 0afaa882da85..600edb3cce7e 100644 --- a/packages/react-dom/src/client/ReactDOM.js +++ b/packages/react-dom/src/client/ReactDOM.js @@ -171,8 +171,8 @@ function unstable_createPortal( } const Internals = { - // Keep in sync with ReactDOMUnstableNativeDependencies.js - // ReactTestUtils.js, and ReactTestUtilsAct.js. This is an array for better minification. + // Keep in sync with ReactTestUtils.js, and ReactTestUtilsAct.js. + // This is an array for better minification. Events: [ getInstanceFromNode, getNodeFromInstance, diff --git a/packages/react-dom/src/test-utils/ReactTestUtils.js b/packages/react-dom/src/test-utils/ReactTestUtils.js index b751ce1362bd..ddc51a422fc1 100644 --- a/packages/react-dom/src/test-utils/ReactTestUtils.js +++ b/packages/react-dom/src/test-utils/ReactTestUtils.js @@ -29,8 +29,7 @@ import { } from 'shared/ReactErrorUtils'; const {findDOMNode} = ReactDOM; -// Keep in sync with ReactDOMUnstableNativeDependencies.js -// ReactDOM.js, and ReactTestUtilsAct.js: +// Keep in sync with ReactDOM.js, and ReactTestUtilsAct.js: const [ getInstanceFromNode, /* eslint-disable no-unused-vars */ diff --git a/packages/react-dom/src/test-utils/ReactTestUtilsAct.js b/packages/react-dom/src/test-utils/ReactTestUtilsAct.js index e50595fae9b8..39a249a098f5 100644 --- a/packages/react-dom/src/test-utils/ReactTestUtilsAct.js +++ b/packages/react-dom/src/test-utils/ReactTestUtilsAct.js @@ -14,8 +14,7 @@ import ReactSharedInternals from 'shared/ReactSharedInternals'; import enqueueTask from 'shared/enqueueTask'; import * as Scheduler from 'scheduler'; -// Keep in sync with ReactDOMUnstableNativeDependencies.js -// ReactDOM.js, and ReactTestUtils.js: +// Keep in sync with ReactDOM.js, and ReactTestUtils.js: const [ /* eslint-disable no-unused-vars */ getInstanceFromNode, diff --git a/packages/react-dom/src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies.js b/packages/react-dom/src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies.js deleted file mode 100644 index 622819940bd2..000000000000 --- a/packages/react-dom/src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies.js +++ /dev/null @@ -1,32 +0,0 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -import * as ReactDOM from 'react-dom'; -import {setComponentTree} from 'legacy-events/EventPluginUtils'; -import ResponderEventPlugin from 'legacy-events/ResponderEventPlugin'; -import ResponderTouchHistoryStore from 'legacy-events/ResponderTouchHistoryStore'; - -// Inject react-dom's ComponentTree into this module. -// Keep in sync with ReactDOM.js, ReactTestUtils.js, and ReactTestUtilsAct.js: -const [ - getInstanceFromNode, - getNodeFromInstance, - getFiberCurrentPropsFromNode, - injectEventPluginsByName, -] = ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.Events; - -setComponentTree( - getFiberCurrentPropsFromNode, - getInstanceFromNode, - getNodeFromInstance, -); - -export { - ResponderEventPlugin, - ResponderTouchHistoryStore, - injectEventPluginsByName, -}; diff --git a/packages/react-dom/unstable-native-dependencies.js b/packages/react-dom/unstable-native-dependencies.js deleted file mode 100644 index ec502fb89069..000000000000 --- a/packages/react-dom/unstable-native-dependencies.js +++ /dev/null @@ -1,10 +0,0 @@ -/** - * Copyright (c) Facebook, Inc. and its affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - * - * @flow - */ - -export * from './src/unstable-native-dependencies/ReactDOMUnstableNativeDependencies'; diff --git a/scripts/rollup/bundles.js b/scripts/rollup/bundles.js index 1cb7bdc48734..8320b9bdc6bd 100644 --- a/scripts/rollup/bundles.js +++ b/scripts/rollup/bundles.js @@ -155,15 +155,6 @@ const bundles = [ externals: ['react'], }, - /* React DOM internals required for react-native-web (e.g., to shim native events from react-dom) */ - { - bundleTypes: [UMD_DEV, UMD_PROD, NODE_DEV, NODE_PROD], - moduleType: RENDERER_UTILS, - entry: 'react-dom/unstable-native-dependencies', - global: 'ReactDOMUnstableNativeDependencies', - externals: ['react', 'react-dom'], - }, - /******* React DOM Server *******/ { bundleTypes: [