Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fabric Todos #12073

Open
1 of 4 tasks
sebmarkbage opened this issue Jan 22, 2018 · 2 comments
Open
1 of 4 tasks

Fabric Todos #12073

sebmarkbage opened this issue Jan 22, 2018 · 2 comments
Labels
React Core Team Opened by a member of the React Core Team Type: Umbrella

Comments

@sebmarkbage
Copy link
Collaborator

sebmarkbage commented Jan 22, 2018 •
edited

For my own notes here are some spill-overs from the Fabric renderer commit.

  • Update currentProps for updates in the commit phase. Needs a host effect to be marked and we need a hook to do host updates in the persistent mode.
  • Actually use currentProps when extracting events in the component tree.
  • Resuming will need to be able to not reuse host nodes used by another thread.
  • Should always clone direct siblings of a changed node, in case they will relayout.
@sebmarkbage sebmarkbage mentioned this issue Jan 22, 2018
Merged
@gaearon
Copy link
Collaborator

gaearon commented Aug 9, 2018

What's still relevant? The point about resuming? Should we add it to general resuming umbrella in #13306?

@sebmarkbage
Copy link
Collaborator Author

It doesn't have to block resuming so I don't think so.

@necolas necolas added the React Core Team Opened by a member of the React Core Team label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
React Core Team Opened by a member of the React Core Team Type: Umbrella
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sebmarkbage @necolas @gaearon