Bug: using MessageChannel prevents node.js process from exiting #20756

just-boris · 2021-02-07T14:13:53Z

Edited: Here's how to fix this: #20756 (comment).

React version: 17.0.1 (latest)

Steps To Reproduce

This code finishes properly in node.js 14, but holds the process open in node.js 15

global.window = global; // simulate JSDOM
require('scheduler');

Since node.js 15, there is a global MessageChannel object now, which prevents node event loop from exiting. To let the process shut down properly, it should either call port.close() or port.unref()

This becomes an issue when testing React code within JSDOM environment, as the test process cannot exit properly.

The current behavior

The process with JSDOM tests never finishes

The expected behavior

The process finishes properly

The text was updated successfully, but these errors were encountered:

rickhanlonii · 2021-02-10T03:47:32Z

Nice find! Do you want to submit a PR to fix?

patil2097 · 2021-02-10T08:15:10Z

I would love to help you on fixing this problem.Can you guide me in submitting a fix? I am really new to open source. @rickhanlonii

amensum · 2021-02-10T09:06:05Z

@rickhanlonii
Can I take this issue for try to fix it and send PR?

amensum · 2021-02-10T15:37:47Z

Issue example:

var { JSDOM } = require('jsdom')

var { window } = new JSDOM()

global.window = window
global.document = window.document

require('scheduler')

rickhanlonii · 2021-02-10T17:30:22Z

Hey all, anyone can take this issue, I'll review the first PR.

The problem is that this feature detection is too naive. In node environments, we should use unstable_no_dom and in browser environments we should use the browser scheduler.

gaearon · 2021-02-17T21:01:04Z

We're going with #20834 as a likely fix in 17.1.0, but it will need more testing.

gaearon · 2021-02-17T23:43:27Z

How to fix this

If you can upgrade to React 17.1.0

When React 17.1.0 comes out, it will contain a fix for this. So upgrading would solve this problem.

(At the time this comment is written, it's not out yet, but I expect it to be out soon.)

If you can't upgrade to React 17.1.0

npm i react-16-node-hanging-test-fix

and add this to your test setup file as THE VERY FIRST IMPORT:

import 'react-16-node-hanging-test-fix';

// All other imports go after it:
import React from 'react'
// ...

(For example, Create React App projects use src/setupTests.js as the test setup file, otherwise you'll need to refer to your test runner's documentation. In Jest, the option is called setupFiles).

This should fix the hanging on Node 15+ with jsdom on older versions of React. We don't plan to be updating them because there's too much risk of breaking something else, as this detection is subtle and there are many possible edge cases.

The package with the fix will print a warning asking you to remove it after you upgrade to React 17.1.0. This is because the fix itself is to disable Node's MessageChannel implementation, which is not ideal in long term.

Let me know if you run into more problems! I'll keep the issue for now until we release 17.1.0.

just-boris · 2021-02-18T00:29:45Z

Brilliant fix :)

delete global.MessageChannel;

Would it make sense to let Node.js devs know that this is happening? Perhaps, they could consider undoing the change in Node 16.

gaearon · 2021-02-18T00:44:29Z

I've briefly chatted with Node folks but it seems pretty difficult to change (and would be a breaking change). In our case, setImmediate is closer to the semantics we need anyway, so it makes sense as a fix. Just a bit risky to port to all the past versions in case people run bad polyfills etc.

More info: facebook/react#20756 (comment)

* pkg: update dependencies webpack/babel/electron * webpack: update configs to migrate to webpack 5 * pkg: update babel config for updated electron * app: stub globalThis for global * sentry: bypass check for isPackaged in renderer: electron / remote * app: replace electron.remote with updated @electron/remote * deps: update sentry * build: replace loaders in webpack configs * ci: update to node 16 * tests: webpack config and react bug More info: facebook/react#20756 (comment) * ci: add windows build and package * util: replace nameChecker with hsd rules module * pkg: document mac arm64 and update package.json scripts * docs: update BUILD.md with new mac package cmd * pkg: move `react-16-node-hanging-test-fix` to devDep * pkg: update non-breaking deps * sentry: load sentry and app based on process Co-authored-by: Rithvik Vibhu <rithvikvibhu@gmail.com>

More info: facebook/react#20756 (comment)

facebook/react#20756 (comment) again

jarredt · 2022-08-25T00:01:00Z

@gaearon -- I think the react-16-node-hanging-test-fix file may have a critical typo:

if (semverGt(version, '17.0.1')) {
  console.error(
    'The `react-16-node-hanging-test-fix` package is no longer needed ' +
    'with React ' + version + ' and may cause issues. Remove this import.'
  )
}

Shouldn't the if be evaluating for "greater than or equal to 17.1.0"? Per your comment and the comment at the top of the package file, the issue is fixed starting with 17.1.0.

Right now it's evaluating "greater than 17.0.1" -- so I'm getting the warning for 17.0.2 even though the issue isn't fixed there.

jarredt · 2022-08-25T00:19:07Z

Also... it looks like maybe the fix actually didn't land until React 18, so maybe needs to be changed to 18.0.0?

Ref: Mention of the fixing PR (#20834) in #24195.

rickhanlonii · 2022-08-25T18:27:09Z

@jarredt what version of react-dom and scheduler are you using? I think the issue is that the code checks react for 17.0.1, but the fix is actually in the scheduler package, through react-dom. If you update react-dom to 17.0.1, the issue should be fixed and you don't need react-16-node-hanging-test-fix.

jarredt · 2022-08-29T20:06:55Z

@rickhanlonii -- ah, so we're using 20.0.2 for react-dom, but one of our storybook-related dependencies is bringing in 0.19.1 as a transitive of react-dom@16.14.0. I assume that may be the issue I'll see if I can get that bumped or excluded from executing in our tests.

andrecrimb · 2022-09-09T14:11:55Z

@jarredt did you manage to get around this issue? We are facing the same problem.

jarredt · 2022-09-09T16:17:50Z

For now I've just kept using the temp fix package but patched it to adjust the version on which it applies the warning. I'm hoping we can update storybook soon and so won't need to make any adjustments after that.

…

On Fri, Sep 9, 2022, 7:12 AM Andre Rosa ***@***.***> wrote: @jarredt <https://github.com/jarredt> did you manage to get around this issue? We are facing the same problem. — Reply to this email directly, view it on GitHub <#20756 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD7LLP5KECNACCBT4WADX6DV5NATTANCNFSM4XHPUFZQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

facebook/react#20756

## Summary - Renamed all tests with their respective TypeScript counterparts. - Fixed jestUtils to properly allow strict checking of AnimatedStyle. - Added type declaration emitting to plugin. - Moved building plugin files before running TypeScript on the project (otherwise TypeScript tests would fail during type-checking). - Added test for jestUtils. - Bumped `jest` version and added `@types/react-test-renderer`. --- Added to `jest-setup.js`: ```diff + delete global.MessageChannel; ``` This line is coming from `react-16-node-hanging-test-fix`. It fixes an error of open handles in `@testing-library/react-native` function `render` and jest going 😵. [Reference](facebook/react#20756). ## Test plan `yarn && yarn jest --detectOpenHandles` ftw

This is to fix yarn test. This simply adds new scripts through the yarn workspace command to run app and lib tests. Currently, the lib testing works by mainly using the same scripts that CRA uses for transpiling typescript to javascript. There is one other thing to note: It looks like if you were to upgrade to 17.0.1 supposedly for react-dom, it would fix jest tests for app to not hang (facebook/react#20756 (comment)). However, jest was still hanging so I just did a delete MessageChannel within src/setupTests.js and we can remove that when we upgrade to React 18.

## Summary - Renamed all tests with their respective TypeScript counterparts. - Fixed jestUtils to properly allow strict checking of AnimatedStyle. - Added type declaration emitting to plugin. - Moved building plugin files before running TypeScript on the project (otherwise TypeScript tests would fail during type-checking). - Added test for jestUtils. - Bumped `jest` version and added `@types/react-test-renderer`. --- Added to `jest-setup.js`: ```diff + delete global.MessageChannel; ``` This line is coming from `react-16-node-hanging-test-fix`. It fixes an error of open handles in `@testing-library/react-native` function `render` and jest going 😵. [Reference](facebook/react#20756). ## Test plan `yarn && yarn jest --detectOpenHandles` ftw

* Minimal exports for app to consume + VerticalBlock and ElementNodeRenderer (#6623) This PR is the first milestone to determine the minimal number of exports needed for app to consume + VerticalBlock + ElementNodeRenderer. Most of the changes are import path changes. Some of the more notable changes to look through are How the @streamlit/lib is built. It's built through the monorepo config for babel (https://babeljs.io/docs/config-files/#monorepos). a. The babel process works by using a custom preset that is mainly babel-preset-react-app but slightly modified in order to make sure glide data grid code is es6 compatible and hard coding isTypeScriptEnabled to True. b. The other keys are adding in the emotion plugin for styled-components, ignoring proto, vendor, test files, and telling babel that frontend is the root directory for babel config. The actual index.ts that is added to frontend/lib Some things to note that will be punt down but worked on later: We also need to look into why protobuf can't be compiled through tsc. Cleaning frontend/app/package.json Cleaning frontend/app/yarn.lock Cleaning frontend/lib/scripts/create.js Determine what's going wrong with globalStyles typing Determine what's going wrong with styled-components typing for EmotionTheme * Change exports for protobuf to be included in index.ts instead of copied through cp command. (#6635) Tim noticed that I was copying the protobuf.js and protobuf.d.ts instead of compiling it through babel. That causes problems because then you have to import by doing import { ... } from "@streamlit/lib/dist/proto" which doesn't make any sense. The reason why I did that was because I was getting an error on first try: `src/proto.js:4:1 - error TS9005: Declaration emit for this file requires using private name 'Radii'. An explicit type annotation may unblock declaration emit. 4 import * as $protobuf from "protobufjs/minimal"; ~~~~~~ src/proto.js:4:1 - error TS9005: Declaration emit for this file requires using private name 'Radio'. An explicit type annotation may unblock declaration emit. 4 import * as $protobuf from "protobufjs/minimal";` I just removed the proto files and did a make protobuf and then tried exporting and that worked, as it should. * Simple fix for globalStyles (#6651) * Fix typing issues for styled-components (#6652) There are going to be 2 emotion.d.ts. Our @streamlit/lib has our own theming and then our app will simply just be consuming from @streamlit/lib which makes sense. * remove extra app directory in frontend dir (#6653) The current folder structure is frontend/app/src/app. We should make it so that it's frontend/app/src and remove the extra app directory. This PR also fixes the audit_license script. * Remove unnecessary files * Fix naming of directories and files * Fix BaseColorPicker directory * Add Fixes that should exist in feature/st-lib * Fix Eslint and Type-checking for st-lib (#6675) This PR is to fix eslint for app and lib. This also adds dependencies that are necessary to lib's package.json. This is done through eslint noticing the necessary dependencies. This PR also does some linting and also does a merge from develop as we need the BaseButton refactoring to stop duplication of exports from the root index.ts. In addition, this PR fixes the type checking github actions by adding new commands. * Fix notices (#6676) * Clean up audit_frontend_licenses * Fix/yarn test (#6681) This is to fix yarn test. This simply adds new scripts through the yarn workspace command to run app and lib tests. Currently, the lib testing works by mainly using the same scripts that CRA uses for transpiling typescript to javascript. There is one other thing to note: It looks like if you were to upgrade to 17.0.1 supposedly for react-dom, it would fix jest tests for app to not hang (facebook/react#20756 (comment)). However, jest was still hanging so I just did a delete MessageChannel within src/setupTests.js and we can remove that when we upgrade to React 18. * Fix regex that I accidentally forgot to commit (#6698) * Fix/cypress (#6699) * Remove unused app dep / dev dep and declarations.d.ts (#6713) * Remove unused app dep / dev dep and declarations.d.ts * Remove d3 color resolution (#6714) * Add dependencies removed from app to lib/package.json * Add pbjs cli * Readd notices * Add watch lib script (#6730) Since @streamlit/lib is separated out to be its own separate lib, we need a script to constantly rebuild when the files change. Will also need to update the contributing wiki after this is merged to develop. * Get rid of yarn start warnings and clean Makefile (#6739) * Remove streamlit.css. I'm not sure where it came from * Fix yarn buildLib * Fix eslintrc * Fix codeql * Add notices and yarn.lock * Fix glide-data-grid versions * Fix nits * Fix nits * Lint and cleanup * Minor cleanup for Block utils as comments got removed * Remove accidentally committed file * Revert "Remove accidentally committed file" This reverts commit 87b7f13. * Fix yarn lock * Fix compilation errors * Fix lint * Fix notices * Remove unnecessary package.json dependencies * Fix package.json versions * Fix yarn.lock and streamlit dialog snapshots * Fix notices * Have faster hot reloading and absolute imports for @streamlit/lib (#6961)  ## Describe your changes - Change imports for `app` to `@streamlit/app/src...` as we removed the `ModuleScopePlugin` which allows us to import out of `app/src`. - Change imports for `lib` to absolute imports - add `tsconfig.dev.json` that is specifically for developement - change `tsconfig.json` for `lib` and `app` - change `.eslintrc` to `.eslintrc.js` in order to gain access to `__dirname` to make typescript configs relative to each project ## GitHub Issue Link (if applicable) ## Testing Plan Manually testing - Explanation of why no additional tests are needed - Unit Tests (JS and/or Python) - E2E Tests - Any manual testing needed? yes https://github.com/streamlit/streamlit/assets/16749069/cc0a5f96-f8cd-487b-b70e-6a4e5823f0e7 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. * Fix minor comments from Lukas

We have a lot of open handles flooding the end of our test results. It seems that they are due to a React issue fixed in 18+. Dan Abramov wrote a small package to fix the issue temporarly. I added it here manually because it has an error in the semver version check. This code should be removed when upgrading React to 18+. facebook/react#20756 (comment)

* Minimal exports for app to consume + VerticalBlock and ElementNodeRenderer (streamlit#6623) This PR is the first milestone to determine the minimal number of exports needed for app to consume + VerticalBlock + ElementNodeRenderer. Most of the changes are import path changes. Some of the more notable changes to look through are How the @streamlit/lib is built. It's built through the monorepo config for babel (https://babeljs.io/docs/config-files/#monorepos). a. The babel process works by using a custom preset that is mainly babel-preset-react-app but slightly modified in order to make sure glide data grid code is es6 compatible and hard coding isTypeScriptEnabled to True. b. The other keys are adding in the emotion plugin for styled-components, ignoring proto, vendor, test files, and telling babel that frontend is the root directory for babel config. The actual index.ts that is added to frontend/lib Some things to note that will be punt down but worked on later: We also need to look into why protobuf can't be compiled through tsc. Cleaning frontend/app/package.json Cleaning frontend/app/yarn.lock Cleaning frontend/lib/scripts/create.js Determine what's going wrong with globalStyles typing Determine what's going wrong with styled-components typing for EmotionTheme * Change exports for protobuf to be included in index.ts instead of copied through cp command. (streamlit#6635) Tim noticed that I was copying the protobuf.js and protobuf.d.ts instead of compiling it through babel. That causes problems because then you have to import by doing import { ... } from "@streamlit/lib/dist/proto" which doesn't make any sense. The reason why I did that was because I was getting an error on first try: `src/proto.js:4:1 - error TS9005: Declaration emit for this file requires using private name 'Radii'. An explicit type annotation may unblock declaration emit. 4 import * as $protobuf from "protobufjs/minimal"; ~~~~~~ src/proto.js:4:1 - error TS9005: Declaration emit for this file requires using private name 'Radio'. An explicit type annotation may unblock declaration emit. 4 import * as $protobuf from "protobufjs/minimal";` I just removed the proto files and did a make protobuf and then tried exporting and that worked, as it should. * Simple fix for globalStyles (streamlit#6651) * Fix typing issues for styled-components (streamlit#6652) There are going to be 2 emotion.d.ts. Our @streamlit/lib has our own theming and then our app will simply just be consuming from @streamlit/lib which makes sense. * remove extra app directory in frontend dir (streamlit#6653) The current folder structure is frontend/app/src/app. We should make it so that it's frontend/app/src and remove the extra app directory. This PR also fixes the audit_license script. * Remove unnecessary files * Fix naming of directories and files * Fix BaseColorPicker directory * Add Fixes that should exist in feature/st-lib * Fix Eslint and Type-checking for st-lib (streamlit#6675) This PR is to fix eslint for app and lib. This also adds dependencies that are necessary to lib's package.json. This is done through eslint noticing the necessary dependencies. This PR also does some linting and also does a merge from develop as we need the BaseButton refactoring to stop duplication of exports from the root index.ts. In addition, this PR fixes the type checking github actions by adding new commands. * Fix notices (streamlit#6676) * Clean up audit_frontend_licenses * Fix/yarn test (streamlit#6681) This is to fix yarn test. This simply adds new scripts through the yarn workspace command to run app and lib tests. Currently, the lib testing works by mainly using the same scripts that CRA uses for transpiling typescript to javascript. There is one other thing to note: It looks like if you were to upgrade to 17.0.1 supposedly for react-dom, it would fix jest tests for app to not hang (facebook/react#20756 (comment)). However, jest was still hanging so I just did a delete MessageChannel within src/setupTests.js and we can remove that when we upgrade to React 18. * Fix regex that I accidentally forgot to commit (streamlit#6698) * Fix/cypress (streamlit#6699) * Remove unused app dep / dev dep and declarations.d.ts (streamlit#6713) * Remove unused app dep / dev dep and declarations.d.ts * Remove d3 color resolution (streamlit#6714) * Add dependencies removed from app to lib/package.json * Add pbjs cli * Readd notices * Add watch lib script (streamlit#6730) Since @streamlit/lib is separated out to be its own separate lib, we need a script to constantly rebuild when the files change. Will also need to update the contributing wiki after this is merged to develop. * Get rid of yarn start warnings and clean Makefile (streamlit#6739) * Remove streamlit.css. I'm not sure where it came from * Fix yarn buildLib * Fix eslintrc * Fix codeql * Add notices and yarn.lock * Fix glide-data-grid versions * Fix nits * Fix nits * Lint and cleanup * Minor cleanup for Block utils as comments got removed * Remove accidentally committed file * Revert "Remove accidentally committed file" This reverts commit 87b7f13. * Fix yarn lock * Fix compilation errors * Fix lint * Fix notices * Remove unnecessary package.json dependencies * Fix package.json versions * Fix yarn.lock and streamlit dialog snapshots * Fix notices * Have faster hot reloading and absolute imports for @streamlit/lib (streamlit#6961)  ## Describe your changes - Change imports for `app` to `@streamlit/app/src...` as we removed the `ModuleScopePlugin` which allows us to import out of `app/src`. - Change imports for `lib` to absolute imports - add `tsconfig.dev.json` that is specifically for developement - change `tsconfig.json` for `lib` and `app` - change `.eslintrc` to `.eslintrc.js` in order to gain access to `__dirname` to make typescript configs relative to each project ## GitHub Issue Link (if applicable) ## Testing Plan Manually testing - Explanation of why no additional tests are needed - Unit Tests (JS and/or Python) - E2E Tests - Any manual testing needed? yes https://github.com/streamlit/streamlit/assets/16749069/cc0a5f96-f8cd-487b-b70e-6a4e5823f0e7 --- **Contribution License Agreement** By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license. * Fix minor comments from Lukas

just-boris added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Feb 7, 2021

jansiegel mentioned this issue Feb 9, 2021

Monorepo Phase 2 handsontable/handsontable#7434

Merged

2 tasks

rickhanlonii added Component: Scheduler good first issue and removed Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug labels Feb 10, 2021

amensum mentioned this issue Feb 10, 2021

Fix for MessageChannel in Node Envs (#20756) #20790

Closed

gaearon mentioned this issue Feb 17, 2021

Use setImmediate when available over MessageChannel #20834

Merged

gaearon closed this as completed in #20834 Feb 17, 2021

gaearon reopened this Feb 17, 2021

gaearon mentioned this issue Mar 1, 2021

Land enableSetImmediate feature flag #20906

Merged

gaearon closed this as completed in #20906 Mar 1, 2021

gaearon mentioned this issue Mar 16, 2021

Proposal: Sandbox setImmediate() in jsdom environment jestjs/jest#11204

Closed

andrewagain mentioned this issue Jul 7, 2021

waitForValueToChange: ReferenceError MessageChannel is not defined testing-library/react-hooks-testing-library#647

Closed

jpage-godaddy mentioned this issue Dec 2, 2021

Hanging open handle in node 16 enzymejs/enzyme#2550

Closed

10 tasks

rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Feb 4, 2022

tests: fix tests not ending (react bug)

6117ffc

More info: facebook/react#20756 (comment)

rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Feb 4, 2022

tests: webpack config and react bug

21db8d2

More info: facebook/react#20756 (comment)

pinheadmz pushed a commit to pinheadmz/bob-wallet that referenced this issue Feb 9, 2022

tests: webpack config and react bug

78085f7

More info: facebook/react#20756 (comment)

lukeburns pushed a commit to lukeburns/bob-wallet that referenced this issue Feb 15, 2022

tests: webpack config and react bug

9f2db66

More info: facebook/react#20756 (comment)

mrazauskas mentioned this issue Mar 15, 2022

fix: set testEnvironment to jsdom in react native example jestjs/jest#12581

Merged

localnerve added a commit to localnerve/element-size-reporter that referenced this issue Mar 23, 2022

@0.11.1, fix node 15+ hang in jsdom - facebook/react#20756

15d1458

localnerve mentioned this issue Mar 23, 2022

@0.11.1, fix node 15+ hang in jsdom localnerve/element-size-reporter#77

Merged

anomiex added a commit to Automattic/jetpack that referenced this issue Apr 11, 2022

Upgrade eval again, it's a React bug.

1f46114

facebook/react#20756 (comment) again

jensdev mentioned this issue Aug 10, 2022

Difference between Node 14 and Node 16 in the basic example callstack/react-native-testing-library#1054

Closed

bradjones1 mentioned this issue Aug 17, 2022

[Bug]: Regression in v28, open handle from MessageChannel()/scheduler jestjs/jest#13144

Closed

tjzel added a commit to software-mansion/react-native-reanimated that referenced this issue Apr 24, 2023

fix react render hanging test

9f24081

facebook/react#20756

tjzel mentioned this issue Apr 24, 2023

Rewrite jest unit tests to TypeScript software-mansion/react-native-reanimated#4399

Merged

stepankuzmin mentioned this issue May 11, 2023

Upgrade to Node v18 mapbox/mapbox-gl-js#12277

Merged

2 tasks

willhuang1997 mentioned this issue May 15, 2023

Fix/yarn test streamlit/streamlit#6681

Merged

GleidsonDaniel mentioned this issue Feb 24, 2024

test: correction and improvement of unit tests in CI RocketChat/Rocket.Chat.ReactNative#5591

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug: using MessageChannel prevents node.js process from exiting #20756

Bug: using MessageChannel prevents node.js process from exiting #20756

just-boris commented Feb 7, 2021 •

edited by gaearon

rickhanlonii commented Feb 10, 2021

patil2097 commented Feb 10, 2021

amensum commented Feb 10, 2021 •

edited

amensum commented Feb 10, 2021 •

edited

rickhanlonii commented Feb 10, 2021

gaearon commented Feb 17, 2021

gaearon commented Feb 17, 2021 •

edited

just-boris commented Feb 18, 2021

gaearon commented Feb 18, 2021

jarredt commented Aug 25, 2022 •

edited

jarredt commented Aug 25, 2022

rickhanlonii commented Aug 25, 2022 •

edited

jarredt commented Aug 29, 2022

andrecrimb commented Sep 9, 2022

jarredt commented Sep 9, 2022 via email

Bug: using MessageChannel prevents node.js process from exiting #20756

Bug: using MessageChannel prevents node.js process from exiting #20756

Comments

just-boris commented Feb 7, 2021 • edited by gaearon

Edited: Here's how to fix this: #20756 (comment).

Steps To Reproduce

The current behavior

The expected behavior

rickhanlonii commented Feb 10, 2021

patil2097 commented Feb 10, 2021

amensum commented Feb 10, 2021 • edited

amensum commented Feb 10, 2021 • edited

rickhanlonii commented Feb 10, 2021

gaearon commented Feb 17, 2021

gaearon commented Feb 17, 2021 • edited

How to fix this

If you can upgrade to React 17.1.0

If you can't upgrade to React 17.1.0

just-boris commented Feb 18, 2021

gaearon commented Feb 18, 2021

jarredt commented Aug 25, 2022 • edited

jarredt commented Aug 25, 2022

rickhanlonii commented Aug 25, 2022 • edited

jarredt commented Aug 29, 2022

andrecrimb commented Sep 9, 2022

jarredt commented Sep 9, 2022 via email

just-boris commented Feb 7, 2021 •

edited by gaearon

amensum commented Feb 10, 2021 •

edited

amensum commented Feb 10, 2021 •

edited

gaearon commented Feb 17, 2021 •

edited

jarredt commented Aug 25, 2022 •

edited

rickhanlonii commented Aug 25, 2022 •

edited