Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The source code of v16.14.0 is inconsistent with the release package. #22432

Closed
amorphousDj opened this issue Sep 26, 2021 · 7 comments
Closed
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug

Comments

@amorphousDj
Copy link

I downloaded and compiled the source code of v16.14.0. It is found that the compiled code is inconsistent with the code of the release package. Some bugs #18539 that were only fixed in version 17.0.0 have been fixed in my compiled code. Of course, it has not been fixed in the v16.14.0 release package. I checked the merge record of these repair codes, and it has indeed been merged into the v16.14.0 tag.

I want to know which commit record corresponds to the actual source code of the v16.14.0 release package.
@gaearon Please help me.

React version: 16.14.0

Steps To Reproduce

The current behavior

The expected behavior

@amorphousDj amorphousDj added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Sep 26, 2021
@bvaughn
Copy link
Contributor

bvaughn commented Sep 26, 2021

I downloaded and compiled the source code of v16.14.0.

How did you determine which source revision to download?

According to the build info metadata, that release was prepared from da83408.

@amorphousDj
Copy link
Author

amorphousDj commented Sep 27, 2021

I downloaded and compiled the source code of v16.14.0.

How did you determine which source revision to download?

According to the build info metadata, that release was prepared from da83408.

I downloaded the source code from release log.

I checked da83408, it's the source code of v16.13.1 not v16.14.0.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 27, 2021

That's interesting. According to our build script metadata, 16.3.1 and 16.14.0 were both built and release from the same source.

My guess is that someone (@gaearon? @acdlite?) did a manual release of 16.14.0 on top of 16.13.1. Looking at the change log it seems like the only purpose of this release was to support the new JSX transform added by @lunaruan in #18299.

@bvaughn
Copy link
Contributor

bvaughn commented Sep 27, 2021

The tags page shows 16.14.0 as 4337c1c, but then it also shows that for 15.7.0 which was also manually released for the new JSX transform.

I think the issue here is likely just that we did a one-off release to add support for the new JSX transform to older 15 and 16 stable releases (rather than using our normal release script/process).

I'm going to close this issue. I don't think there's anything we can do about it at this point. This isn't worth the churn that unpublishing the release from NPM would cause. I suppose we could fix the NPM tag (if someone knew which commit to point to, I do not).

@bvaughn bvaughn closed this as completed Sep 27, 2021
@amorphousDj
Copy link
Author

I downloaded and compiled the source code of v16.14.0.

How did you determine which source revision to download?

According to the build info metadata, that release was prepared from da83408.

Thanks for your reply. I'm sure da83408 is the source code of v16.14.0. I compiled the source code without setting RELEASE_CHANNEL. After I set it equal to stable, they became consistent.

@amorphousDj
Copy link
Author

The tags page shows 16.14.0 as 4337c1c, but then it also shows that for 15.7.0 which was also manually released for the new JSX transform.

I think the issue here is likely just that we did a one-off release to add support for the new JSX transform to older 15 and 16 stable releases (rather than using our normal release script/process).

I'm going to close this issue. I don't think there's anything we can do about it at this point. This isn't worth the churn that unpublishing the release from NPM would cause. I suppose we could fix the NPM tag (if someone knew which commit to point to, I do not).

I'm sure da83408 commit point to the NPM tag. Please fix it.

@bvaughn
Copy link
Contributor

bvaughn commented Jan 12, 2022

I'm going to lock this issue.

@facebook facebook locked as resolved and limited conversation to collaborators Jan 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug
Projects
None yet
Development

No branches or pull requests

2 participants