Deprecate undocumented ReactTestUtils.SimulateNative API #13407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details of bundled changes.Comparing: 69e2a0d...05da6ad react-dom
Generated by 🚫 dangerJS |
Akshat-Jain
approved these changes
Sep 14, 2018
Kachulio1
approved these changes
Jan 7, 2019
|
Needs rebase. Probably still want to do this before 17. Although we may want to deprecate even more so maybe that needs to be a part of some other deprecation list. |
trueadm
approved these changes
Apr 2, 2020
gaearon
force-pushed
the
no-simulate-native
branch
from
05da6ad
to
6bc9933
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 234905a:
|
|
I also wonder if we should remove the API entirely when the modern event system flag is enabled? That way I can remove all the internal requirements to use it from the modern event system, saving a bunch of bytes and making the Flow types nicer? I can always do in a follow up too. |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (stable) |
Details of bundled changes.Comparing: 7dfdff4...234905a react-dom
ReactDOM: size: 0.0%, gzip: 0.0% Size changes (experimental) |
gaearon
force-pushed
the
no-simulate-native
branch
from
6bc9933
to
234905a
Compare
This was referenced Mar 6, 2021
This was referenced Mar 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11656.
This API is counter-intuitive because it only simulates the React dispatch of a native event, as opposed to simulating what the browser would do on an event. I've seen quite a few people confused by this. It's also completely undocumented.
I think it's a liability to keep this around.