Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flushSync to noop in life cycles but with a warning #18759

Merged
merged 1 commit into from Apr 28, 2020

Conversation

sebmarkbage
Copy link
Collaborator

We already did this for flushControlled before.

It doesn't make sense to flush in a life-cycle or render because React can't do the work right then. Even if we did, it would make all other life-cycles more confusing.

There might be some opportunity by flushing right at the end of a React batch to do a second one. However, you can also call flush sync in the next tick to get more or less the same effect.

The only reason to relax this to a log is that it is very easy to accidentally add this to paths called from life-cycles since anything could call it. It might just be able to work in most cases.

In the case it's called from a layout effect, the priority of scheduled work will be sync anyway. In the case where it's called in passive effects, I could increase the priority but that's just a fallback case. It errors anyway. If it's in passive effects it full of race conditions anyway so probably it's fine to leave it like this.

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Apr 28, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2b80075:

Sandbox Source
goofy-hooks-4g4li Configuration

@sizebot
Copy link

sizebot commented Apr 28, 2020

No significant bundle size changes to report.

Size changes (stable)

Generated by 🚫 dangerJS against 2b80075

@sizebot
Copy link

sizebot commented Apr 28, 2020

No significant bundle size changes to report.

Size changes (experimental)

Generated by 🚫 dangerJS against 2b80075

@sebmarkbage sebmarkbage merged commit 53ce0c3 into facebook:master Apr 28, 2020
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed React Core Team Opened by a member of the React Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants