Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about CompactRange behavior with option atomic_flush=true #12553

Open
max-509 opened this issue Apr 17, 2024 · 0 comments
Open

Question about CompactRange behavior with option atomic_flush=true #12553

max-509 opened this issue Apr 17, 2024 · 0 comments

Comments

@max-509
Copy link

max-509 commented Apr 17, 2024

Hi RocksDB community!

When I set option atomic_flush=true, CompactRange() function flushes all CFs in database instance. But with atomic_flush=false CompactRange() flushes only provided CF. Same behavior in IngestExternalFiles().

In Flush(const FlushOptions&, ColumnFamilyHandle*) function only single CF will be flushed with atomic_flush=true.

I tried to find explanation of this behavior in original commit that introduced this option (#4023), but not found. Can someone explain me is it bug or expected behavior?

I understand that it can be related to case, where we open database with disableWAL=true option, but in my case I want to make manual compaction for only selected CF.

If it turns out to be a bug, can I submit PR with fixes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant