Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO prefetch is invalid #12632

Open
kaede11 opened this issue May 9, 2024 · 0 comments
Open

IO prefetch is invalid #12632

kaede11 opened this issue May 9, 2024 · 0 comments

Comments

@kaede11
Copy link

kaede11 commented May 9, 2024

Note: Please use Issues only for bug reports. For questions, discussions, feature requests, etc. post to dev group: https://groups.google.com/forum/#!forum/rocksdb or https://www.facebook.com/groups/rocksdb.dev

Expected behavior

when we set the options readahead_size = 512 * 1024, the expected behavior is to retrieve data from the prefetch buffer

Actual behavior

In function RandomAccessFileReader::ReadAsyncCallback, when use_direct_io() == false, the req.result has not been set appropriately

The data in the prefetch buf is not valid, as the value of the FilePrefetchBuffer::bufs_[index].buffer_.CurrentSize() has not been appropriately set when io callback in FilePrefetchBuffer::PrefetchAsyncCallback. As a result, it was read directly from the file again.

Steps to reproduce the behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant