Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR links for forked repo dont work in ISL #811

Open
alex-statsig opened this issue Jan 9, 2024 · 1 comment
Open

PR links for forked repo dont work in ISL #811

alex-statsig opened this issue Jan 9, 2024 · 1 comment
Labels
isl Interactive smart log

Comments

@alex-statsig
Copy link
Contributor

alex-statsig commented Jan 9, 2024

When using sapling on a forked repo, PRs are submitted against the original repo to merge changes in. However, ISL doesnt seem to load PRs from the original repo, so it fails to show the status / PR link. The link from sl ssl works fine however.

ISL:
Screenshot 2024-01-09 at 12 47 00 PM
Notice in particular the spinner next to PR number; as a result, clicking it does not open the PR

SSL:
Screenshot 2024-01-09 at 12 45 17 PM

@zzl0
Copy link
Contributor

zzl0 commented Jan 12, 2024

Thanks for posting the issue. cc @evangrayk @quark-zju

@zzl0 zzl0 added the isl Interactive smart log label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
isl Interactive smart log
Projects
None yet
Development

No branches or pull requests

2 participants