Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ReviewStack] No limit on diff size #841

Open
stellar-novas opened this issue Feb 22, 2024 · 2 comments
Open

[ReviewStack] No limit on diff size #841

stellar-novas opened this issue Feb 22, 2024 · 2 comments

Comments

@stellar-novas
Copy link

ReviewStack appears to have no max diff size, and always attempts to generate one. This is problematic for PRs with very large diffs, such as https://reviewstack.dev/DeltaV-Station/Delta-v/pull/883, which contains a diff for a generated file of 127,901 characters.
@quark-zju
Copy link
Contributor

Would you like to send a PR?

@stellar-novas
Copy link
Author

I can try to, I'm not sure what I'm doing though, I'm not the greatest developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@quark-zju @stellar-novas