Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sl pr submit can overwrite another PR in race condition #848

Open
alex-statsig opened this issue Mar 5, 2024 · 0 comments
Open

sl pr submit can overwrite another PR in race condition #848

alex-statsig opened this issue Mar 5, 2024 · 0 comments

Comments

@alex-statsig
Copy link
Contributor

Haven't had this happen before, but twice today ran into an issue where one user's sl pr submit (via ISL UI in vscode) pushed changes to someone else's branch/PR (both created via sapling). Presumably we both submitted PRs at the same time, they both picked the same PR number, and committed changes to that branch, but theirs ultimately failed when creating the PR itself (but not before pushing changes to my branch).

I'm not sure if this is a recent regression or just a result of a high volume of PRs today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant