Fix the way /proc/net/unix is being parsed #589
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dumpapp stopped working for me because /proc/net/unix has two spaces to separate state from inode when the inode length is less than the maximum inode length (123 vs 1234). E.g.: ``` 00000000: 00000002 00000000 00010000 0001 01 76292 /dev/socket/cryptd 00000000: 00000002 00000000 00010000 0001 01 3836 @stetho_com.facebook.wakizashi_devtools_remote ``` We should be parsing this with `\s+` and not a simple space since the output date is a table that is formatted to look like columns in the print out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dumpapp stopped working for me because /proc/net/unix has two spaces to separate state from inode when the inode length is less than the maximum inode length (123 vs 1234).
E.g.:
We should be parsing this with
\s+and not a simple space since the output date is a table that is formatted to look like columns in the print out.I tested this by running dumpapp in a situation like the one mentioned above.