Add support for ADB_SERVER_SOCKET in dumpapp #623
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are multiple ways to set the adb server connection information in the environment. This commit adds support for `ADB_SERVER_SOCKET`. Set a valid server socket environment variable: ``` $ export ADB_SERVER_SOCKET=tcp:localhost:5038 $ adb devices List of devices attached * daemon not running; starting now at tcp:localhost:5038 * daemon started successfully ``` Now dumpapp doesn't fail anymore: ``` $ scripts/dumpapp Failure to target device None: no devices/emulators found ``` It does fail when the socket spec is invalid/unsupported: ``` $ export ADB_SERVER_SOCKET=nope $ scripts/dumpapp ... stetho_open.HumanReadableError: Invalid or unsupported socket spec 'nope' specified in ADB_SERVER_SOCKET. ``` ``` $ export ADB_SERVER_SOCKET=tcp:localhost:abc $ scripts/dumpapp ... stetho_open.HumanReadableError: Invalid integer 'abc' specified in ANDROID_ADB_SERVER_PORT or ADB_SERVER_SOCKET. ```
|
Great work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple ways to set the adb server connection information in the
environment. This commit adds support for
ADB_SERVER_SOCKET.Set a valid server socket environment variable:
Now dumpapp doesn't fail anymore:
It does fail when the socket spec is invalid/unsupported: