Simplify ArrayBufferView check #702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Fix the `Loadable` export for TypeScript, which was broken in D24281676 (facebookexperimental@0851dc6). Differential Revision: D24653590 fbshipit-source-id: 4dca505684da846b8c74ea548a283b0f6906cfa2
Summary: Various fixes for some Flow errors in OSS build. Differential Revision: D24642676 fbshipit-source-id: dbc88a037199fdc64dbaa220ab375ec36a039296
Summary: OSS build CI was failing due to eslint and flowtype. I've made some fixes to have CI pass for OSS repo. cc drarmstr Pull Request resolved: facebookexperimental#692 Differential Revision: D24654484 Pulled By: drarmstr fbshipit-source-id: 36d75d1c40a5afd22ee6e8469b6e536eba16d93d
Summary: Bump version to 0.1.2 for TypeScript fix Differential Revision: D24655028 fbshipit-source-id: d02fa1dfbfde2ff8e521e321c37b751a21506fd6
Summary: Simplify the `ArrayBufferView` check by using [ArrayBuffer.isView()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView) which should be supported on all browsers. Try to avoid breaking React Native... Differential Revision: D24655610 fbshipit-source-id: 773085ad4aa5f427cb3bc03c73d9004530396424
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24655610 |
|
Polyfill if needed: jvilk/BrowserFS#193 (comment) |
Thanks for the link if anyone needs it. Coverage looks pretty decent now: |
|
This pull request has been merged in 50a911e. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#702 Simplify the `ArrayBufferView` check by using [ArrayBuffer.isView()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView) which should be supported on all browsers. Try to avoid breaking React Native... Reviewed By: davidmccabe Differential Revision: D24655610 fbshipit-source-id: 52f105a7b3aefeaef79c1c25ed390cc7c730418a
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#702 Simplify the `ArrayBufferView` check by using [ArrayBuffer.isView()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/ArrayBuffer/isView) which should be supported on all browsers. Try to avoid breaking React Native... Reviewed By: davidmccabe Differential Revision: D24655610 fbshipit-source-id: 52f105a7b3aefeaef79c1c25ed390cc7c730418a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Simplify the
ArrayBufferViewcheck by using ArrayBuffer.isView() which should be supported on all browsers.Try to avoid breaking React Native...
Differential Revision: D24655610