Big warning message to tell people to add a RecoilRoot to their component tree #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent tree Summary: When using a Recoil hook outside of `<RecoilRoot>` using mutable source, the following error gets thrown: ``` Error: Cannot read property '_getVersion' of null ``` This is exceptionally cryptic and doesn't give any hint as to how to fix the problem. Let's show a more helpful error message instead. Reviewed By: drarmstr Differential Revision: D24643931 fbshipit-source-id: 4839d056986da0701aa10235ac12dc00b8727647
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D24643931 |
|
This pull request has been merged in 19bfa75. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
…nent tree (#712) Summary: Pull Request resolved: facebookexperimental/Recoil#712 When using a Recoil hook outside of `<RecoilRoot>` using mutable source, the following error gets thrown: ``` Error: Cannot read property '_getVersion' of null ``` This is exceptionally cryptic and doesn't give any hint as to how to fix the problem. Let's show a more helpful error message instead. Reviewed By: drarmstr, davidmccabe Differential Revision: D24643931 fbshipit-source-id: c167196db8ebf2cf8ac3bc70557a33ed55c489fe
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
…nent tree (#712) Summary: Pull Request resolved: facebookexperimental/Recoil#712 When using a Recoil hook outside of `<RecoilRoot>` using mutable source, the following error gets thrown: ``` Error: Cannot read property '_getVersion' of null ``` This is exceptionally cryptic and doesn't give any hint as to how to fix the problem. Let's show a more helpful error message instead. Reviewed By: drarmstr, davidmccabe Differential Revision: D24643931 fbshipit-source-id: c167196db8ebf2cf8ac3bc70557a33ed55c489fe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When using a Recoil hook outside of
<RecoilRoot>using mutable source, the following error gets thrown:This is exceptionally cryptic and doesn't give any hint as to how to fix the problem. Let's show a more helpful error message instead.
Reviewed By: drarmstr
Differential Revision: D24643931