-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
report subscribing components #714
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add `useRecoilValueInfo()` hook which acts similar to `getInfo()` method on `Snapshot`, except peeks the info for the current state. Differential Revision: D24718803 fbshipit-source-id: 3712ea739db99f6347e5459782fb196be560265c
Summary: Report components which are subscribing to atoms and selectors via `useGetRecoilValueInfo()`. Note that `Snapshot#getInfo()` will not report any subscribing components at this time. This currently reports a string of the component name. But, we likely want to change that to something more specific/useful. Reviewed By: maxijb Differential Revision: D24718812 fbshipit-source-id: 84489bcff5a2df7a999648a5661f55657b0bd083
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Nov 5, 2020
This pull request was exported from Phabricator. Differential Revision: D24718812 |
Document in #744 |
This pull request has been merged in c6d786b. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#714 Report components which are subscribing to atoms and selectors via `useGetRecoilValueInfo()`. Note that `Snapshot#getInfo()` will not report any subscribing components at this time. This currently reports a string of the component name. But, we likely want to change that to something more specific/useful. Reviewed By: maxijb Differential Revision: D24718812 fbshipit-source-id: 8f8bfb298592e2d2d78b845287269805d8ad18f9
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#714 Report components which are subscribing to atoms and selectors via `useGetRecoilValueInfo()`. Note that `Snapshot#getInfo()` will not report any subscribing components at this time. This currently reports a string of the component name. But, we likely want to change that to something more specific/useful. Reviewed By: maxijb Differential Revision: D24718812 fbshipit-source-id: 8f8bfb298592e2d2d78b845287269805d8ad18f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
devtools
enhancement
New feature or request
fb-exported
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Report components which are subscribing to atoms and selectors via
useGetRecoilValueInfo()
.Note that
Snapshot#getInfo()
will not report any subscribing components at this time.This currently reports a string of the component name. But, we likely want to change that to something more specific/useful.
Reviewed By: maxijb
Differential Revision: D24718812