Use dynamic resolve config to build for react-native #748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
There was a problem hiding this comment.
@mondaychen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@mondaychen merged this pull request in 8e1e2ee. |
Closed
mondaychen
added a commit
to mondaychen/Recoil
that referenced
this pull request
Dec 15, 2020
…kexperimental#748)" This reverts commit 8e1e2ee.
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary:
Instead of using different suffix (.native.js), use a different resolve plugin to build for react native support, so we don't have a file that's seemingly useless to codemod bots.
Output:
head native/recoil.js
```
import reactNative from 'react-native';
import react from 'react';
```
head cjs/recoil.js
```
'use strict';
Object.defineProperty(exports, '__esModule', { value: true });
function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'default' in ex) ? ex['default'] : ex; }
var reactDom = _interopDefault(require('react-dom'));
var react = _interopDefault(require('react'));
```
head es/recoil.js
```
import reactDom from 'react-dom';
import react from 'react';
```
Pull Request resolved: facebookexperimental/Recoil#748
Reviewed By: drarmstr
Differential Revision: D25065347
Pulled By: mondaychen
fbshipit-source-id: 743016f4d114af73ed94663adc06f896737e285d
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary:
Instead of using different suffix (.native.js), use a different resolve plugin to build for react native support, so we don't have a file that's seemingly useless to codemod bots.
Output:
head native/recoil.js
```
import reactNative from 'react-native';
import react from 'react';
```
head cjs/recoil.js
```
'use strict';
Object.defineProperty(exports, '__esModule', { value: true });
function _interopDefault (ex) { return (ex && (typeof ex === 'object') && 'default' in ex) ? ex['default'] : ex; }
var reactDom = _interopDefault(require('react-dom'));
var react = _interopDefault(require('react'));
```
head es/recoil.js
```
import reactDom from 'react-dom';
import react from 'react';
```
Pull Request resolved: facebookexperimental/Recoil#748
Reviewed By: drarmstr
Differential Revision: D25065347
Pulled By: mondaychen
fbshipit-source-id: 743016f4d114af73ed94663adc06f896737e285d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using different suffix (.native.js), use a different resolve plugin to build for react native support, so we don't have a file that's seemingly useless to codemod bots.
Output:
head native/recoil.js
head cjs/recoil.js
head es/recoil.js