Avoid freezing Errors #852
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Avoid freezing `Error` objects. They are usually encountered when thrown by selectors. This can disrupt environments which expect mutable Errors. Freezing is intended to help catch issues with users changing state by mutating objects and errors are not usually mutated to reflect state changes anyway. Differential Revision: D26090167 fbshipit-source-id: 5651f01d0953c3eda815742ecdf992ba425788d4
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26090167 |
|
This pull request has been merged in ac9df69. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#852 Avoid freezing `Error` objects. They are usually encountered when thrown by selectors. This can disrupt environments which expect mutable Errors. Freezing is intended to help catch issues with users changing state by mutating objects and errors are not usually mutated to reflect state changes anyway. Reviewed By: mondaychen Differential Revision: D26090167 fbshipit-source-id: b2450bc90441701ad6bf3c0db2783ae60285d25d
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#852 Avoid freezing `Error` objects. They are usually encountered when thrown by selectors. This can disrupt environments which expect mutable Errors. Freezing is intended to help catch issues with users changing state by mutating objects and errors are not usually mutated to reflect state changes anyway. Reviewed By: mondaychen Differential Revision: D26090167 fbshipit-source-id: b2450bc90441701ad6bf3c0db2783ae60285d25d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Avoid freezing
Errorobjects. They are usually encountered when thrown by selectors. This can disrupt environments which expect mutable Errors. Freezing is intended to help catch issues with users changing state by mutating objects and errors are not usually mutated to reflect state changes anyway.Differential Revision: D26090167