Add error message for useRecoilCallback() misuse #870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Add a slightly better error message when `useRecoilCallback()` is misused when a user calls it with a function that just returns a value instead a function that takes the callback interface and returns a function that matches the signature of the callback we are producing. Before: `Uncaught TypeError: fn(...) is not a function` After: `Uncaught Error: useRecoilCallback() accepts a function parameter which returns a function that matches the signature of the callback function.` Flow and TypeScript will catch this, but this runtime check may help those not using a type system. (facebookexperimental#851) Differential Revision: D26219475 fbshipit-source-id: 918150332c36435f99027f3b4841c881216875ca
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26219475 |
|
This pull request has been merged in 3d6fb75. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#870 Add a slightly better error message when `useRecoilCallback()` is misused when a user calls it with a function that just returns a value instead a function that takes the callback interface and returns a function that matches the signature of the callback we are producing. Before: `Uncaught TypeError: fn(...) is not a function` After: `Uncaught Error: useRecoilCallback() accepts a function parameter which returns a function that matches the signature of the callback function.` Flow and TypeScript will catch this, but this runtime check may help those not using a type system. (#851) Reviewed By: davidmccabe Differential Revision: D26219475 fbshipit-source-id: 7d19cbad36fe4f46b2d14e4fdd3efcfce20eb450
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#870 Add a slightly better error message when `useRecoilCallback()` is misused when a user calls it with a function that just returns a value instead a function that takes the callback interface and returns a function that matches the signature of the callback we are producing. Before: `Uncaught TypeError: fn(...) is not a function` After: `Uncaught Error: useRecoilCallback() accepts a function parameter which returns a function that matches the signature of the callback function.` Flow and TypeScript will catch this, but this runtime check may help those not using a type system. (#851) Reviewed By: davidmccabe Differential Revision: D26219475 fbshipit-source-id: 7d19cbad36fe4f46b2d14e4fdd3efcfce20eb450
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add a slightly better error message when
useRecoilCallback()is misused when a user calls it with a function that just returns a value instead a function that takes the callback interface and returns a function that matches the signature of the callback we are producing.Before:
Uncaught TypeError: fn(...) is not a functionAfter:
Uncaught Error: useRecoilCallback() accepts a function parameter which returns a function that matches the signature of the callback function.Flow and TypeScript will catch this, but this runtime check may help those not using a type system. (#851)
Differential Revision: D26219475