Prevent notifyBatcherOfChange from updating state after a Batcher is unmounted #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D26895327 |
derekxu16
added a commit
to derekxu16/Recoil
that referenced
this pull request
Mar 9, 2021
…unmounted (facebookexperimental#917) Summary: Pull Request resolved: facebookexperimental#917 This sets `notifyBatcherOfChange` to an empty function when Batcher unmounts. Previously, if you unmounted RecoilRoot when an asynchronous selector was still pending, `notifyBatcherOfChange` on line 383 would be called after Batcher was already unmounted, causing the following error to be thrown: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application." Fixes facebookexperimental#897 Reviewed By: drarmstr, davidmccabe Differential Revision: D26895327 fbshipit-source-id: 938612144b6234481772d272b86878b856c7369f
derekxu16
force-pushed
the
export-D26895327
branch
from
74317a3
to
c2c4d2f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26895327 |
…unmounted (facebookexperimental#917) Summary: Pull Request resolved: facebookexperimental#917 This sets `notifyBatcherOfChange` to an empty function when Batcher unmounts. Previously, if you unmounted RecoilRoot when an asynchronous selector was still pending, `notifyBatcherOfChange` on line 383 would be called after Batcher was already unmounted, causing the following error to be thrown: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application." Fixes facebookexperimental#897 Reviewed By: drarmstr, davidmccabe Differential Revision: D26895327 fbshipit-source-id: b44e7fdba968f97ae085dab53dc502cc67be5673
derekxu16
force-pushed
the
export-D26895327
branch
from
c2c4d2f
to
bae64af
Compare
|
This pull request was exported from Phabricator. Differential Revision: D26895327 |
|
This pull request has been merged in dc87f29. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
…unmounted (#917) Summary: Pull Request resolved: facebookexperimental/Recoil#917 This sets `notifyBatcherOfChange` to an empty function when Batcher unmounts. Previously, if you unmounted RecoilRoot when an asynchronous selector was still pending, `notifyBatcherOfChange` on line 383 would be called after Batcher was already unmounted, causing the following error to be thrown: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application." Fixes #897 Reviewed By: drarmstr, davidmccabe Differential Revision: D26895327 fbshipit-source-id: 402e1743bc5e61c4b63c44c6de9fe7fb3f4d180b
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
…unmounted (#917) Summary: Pull Request resolved: facebookexperimental/Recoil#917 This sets `notifyBatcherOfChange` to an empty function when Batcher unmounts. Previously, if you unmounted RecoilRoot when an asynchronous selector was still pending, `notifyBatcherOfChange` on line 383 would be called after Batcher was already unmounted, causing the following error to be thrown: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application." Fixes #897 Reviewed By: drarmstr, davidmccabe Differential Revision: D26895327 fbshipit-source-id: 402e1743bc5e61c4b63c44c6de9fe7fb3f4d180b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This sets
notifyBatcherOfChangeto an empty function when Batcher unmounts.Previously, if you unmounted RecoilRoot when an asynchronous selector was still pending,
notifyBatcherOfChangeon line 383 would be called after Batcher was already unmounted, causing the following error to be thrown: "Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application."Fixes #897
Differential Revision: D26895327