Skip to content

Relax no-cond-assign rule #3716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 8, 2018
Merged

Relax no-cond-assign rule #3716

merged 1 commit into from
Jan 8, 2018
+1 −1

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jan 8, 2018

Fixes #2793

@gaearon
Relax no-cond-assign rule

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
2e841cb 
Fixes #2793
@gaearon gaearon added this to the 1.0.18 milestone Jan 8, 2018
@gaearon gaearon merged commit ce07e98 into master Jan 8, 2018
@Timer Timer deleted the gaearon-patch-1 branch January 8, 2018 21:40
@gaearon gaearon mentioned this pull request Jan 15, 2018
Merged
@dependencies dependencies bot mentioned this pull request Jan 15, 2018
Merged
This was referenced Feb 2, 2018
Closed
Closed
Closed
Closed
Pavek pushed a commit to Pavek/create-react-app that referenced this pull request Jul 10, 2018
@gaearon
Relax no-cond-assign rule (facebook#3716)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
dbe3369 
Fixes facebook#2793
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gaearon @facebook-github-bot