Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript and non-Babel environments example out of sync with TypeScript definitions #31

Open
corydeppen opened this issue Jan 3, 2018 · 3 comments

Comments

@corydeppen
Copy link

The universal options in the example (chunkName and resolve) don't exist in the current react-universal-component declaration file. Interestingly, the Flow types contain the properties, though.

Can this example be updated with the appropriate options that should be passed when used in a TypeScript project or can the TypeScript definitions for react-universal-component be updated to reflect the valid options?

/cc @forabi @Alex-Krautmann

@rohmanhm
Copy link
Contributor

Any update?

@ScriptedAlchemy
Copy link
Collaborator

@corydeppen we had some TS defs updated. Does this solve your issue / would you be able to PR it?

I dont know much TS

@cdoublev
Copy link

I believe it's resolved by faceyspacey/react-universal-component#99 and this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants