Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC document allowed type for sensitive features #1250

Open
3 tasks
romanlutz opened this issue Jul 7, 2023 · 4 comments
Open
3 tasks

DOC document allowed type for sensitive features #1250

romanlutz opened this issue Jul 7, 2023 · 4 comments

Comments

@romanlutz
Copy link
Member

Describe the issue linked to the documentation

Our API reference says that sensitive_features needs to be an array, DF, Series, or list, but it doesn't say the type of the individual entries of these structures. We know that strings and integers work, but what about other types?

This item is about three things:

  • check which types work
  • document the expected types (in all methods accepting sensitive features)
  • catch if unexpected types are passed in a centralized location (e.g., the validation code under utils) and return a suitable error message.

It's fine if someone only wants to do one of these tasks as we can check them off individually.

@yavuzs
Copy link

yavuzs commented Oct 10, 2023

hi, can i take it ?

@romanlutz
Copy link
Member Author

@yavuzs of course. Let us know if you questions!

@miacodehub
Copy link

Hi is this still open? I'd love to work on this if it is.

@romanlutz
Copy link
Member Author

Yes, go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants