Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Reassess pandas and scikit-learn bounds #1288

Open
riedgar-ms opened this issue Sep 22, 2023 · 9 comments
Open

MNT Reassess pandas and scikit-learn bounds #1288

riedgar-ms opened this issue Sep 22, 2023 · 9 comments
Assignees
@adrinjalali @mmadaio @romanlutz @alliesaizan @MiroDudik @hildeweerts @riedgar-ms
Labels
CI Continues Integration and build related issues dependencies Pull requests that update a dependency file

Comments

@riedgar-ms
Copy link
Member

The current bounds listed for pandas and scikit-learn in requirements.txt are laughably out of date, and we're getting test failures due to deprecation warnings.
@riedgar-ms riedgar-ms added dependencies Pull requests that update a dependency file CI Continues Integration and build related issues labels Sep 22, 2023
@riedgar-ms riedgar-ms mentioned this issue Sep 22, 2023
Merged
7 tasks
@adrinjalali
Copy link
Member

we should support like, last two years or something, not more.

@riedgar-ms
Copy link
Member Author

So PR #1287 updates the SciKit-Learn lower bound (assuming we merge) but that still leaves pandas. And that has a lot of deprecation warnings

@adrinjalali
Copy link
Member

yeah, and we need to make sure we work with latest pandas, which is very different. Also, we might need to do changes related to the upcoming numpy=2 release.

@riedgar-ms
Copy link
Member Author

Looks like we also have issues with things being deprecated in numpy as well

@riedgar-ms riedgar-ms mentioned this issue Sep 22, 2023
Merged
7 tasks
@riedgar-ms
Copy link
Member Author

As mentioned on Discord, there's a problem with pandas. Python 3.8 is only supported up to pandas 2.0. Version 2.1 of pandas deprecates DataFrame.applymap() and introduces DataFrame.map() as a replacement.

This means that #1289 is actually incompatible with Python 3.8, and should perhaps be reverted. The issue it addressed can be hushed (for how) in pyproject.toml

@adrinjalali
Copy link
Member

we could also do 3.9+ which would be 3.9, 3.10, 3.11, and the upcoming 3.12, which should be enough

@riedgar-ms
Copy link
Member Author

Thoughts @fairlearn/fairlearn-maintainers ? I wouldn't object to bumping to >3.9, but this should probably be more widely considered.

@hildeweerts
Copy link
Contributor

I also don't mind bumping to 3.9+ (and it's a good incentive for me to update my own installation, lol)

@riedgar-ms
Copy link
Member Author

Thanks.... @MiroDudik @mmadaio @alliesaizan ?

@riedgar-ms riedgar-ms mentioned this issue Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adrinjalali adrinjalali

@mmadaio mmadaio

@romanlutz romanlutz

@alliesaizan alliesaizan

@MiroDudik MiroDudik

@hildeweerts hildeweerts

@riedgar-ms riedgar-ms

Labels
CI Continues Integration and build related issues dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@adrinjalali @mmadaio @romanlutz @alliesaizan @MiroDudik @hildeweerts @riedgar-ms