Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add german adjectives #1023

Merged
merged 4 commits into from
May 30, 2022
Merged

feat: add german adjectives #1023

merged 4 commits into from
May 30, 2022

Conversation

rsstiglitz
Copy link
Contributor

Just some adjectives for de and de_AT taken from here. I didn't add them for de_CH because I think swiss german doesn't have ß and I'm unsure.

I also removed some words because of their "special" declension (for the other ones you can add an "e" and it makes sense (breite, stille), for the removed ones it wouldn't make sense). Just to make it more "machine-usable", I guess...

I also removed "christlich" (christian) and "männlich" (male) because there were no counterparts. 💩

@rsstiglitz rsstiglitz requested a review from a team as a code owner May 30, 2022 12:04
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1023 (999b189) into main (5ded656) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1023      +/-   ##
==========================================
- Coverage   99.67%   99.67%   -0.01%     
==========================================
  Files        2115     2119       +4     
  Lines      227025   227439     +414     
  Branches      983      982       -1     
==========================================
+ Hits       226280   226691     +411     
- Misses        725      728       +3     
  Partials       20       20              
Impacted Files Coverage Δ
src/locales/de/index.ts 100.00% <100.00%> (ø)
src/locales/de/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/de/word/index.ts 100.00% <100.00%> (ø)
src/locales/de_AT/index.ts 100.00% <100.00%> (ø)
src/locales/de_AT/word/adjective.ts 100.00% <100.00%> (ø)
src/locales/de_AT/word/index.ts 100.00% <100.00%> (ø)
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️

@Shinigami92
Copy link
Member

Erstmal vielen dank für deinen Beitrag zu Faker 🙂
Ich review dann mal ... 😸

@Shinigami92 Shinigami92 added the c: locale Permutes locale definitions label May 30, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone May 30, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels May 30, 2022
@Shinigami92 Shinigami92 requested review from a team May 30, 2022 13:19
@ST-DDT ST-DDT requested review from a team May 30, 2022 16:42
@Shinigami92 Shinigami92 merged commit 1b9a920 into faker-js:main May 30, 2022
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022
@xDivisionByZerox xDivisionByZerox added the m: word Something is referring to the word module label Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: word Something is referring to the word module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants