feat: always use https for loremflickr

[bfanger]

When using https for you testpage you can only use the imageUrl function, all the other image helper functions will generate http:// urls.

This results in the image being blocked by the browser:

Mixed Content: The page at 'https://domain.tld/storybook/' was loaded over HTTPS,
but requested an insecure image 'http://loremflickr.com/100/100/nightlife?w=200&fm=webp&q=85'. 
This request has been blocked; the content must be served over HTTPS.

https image urls also work when the the page is hosted on http, in fact the http image urls will be redirected to https by lorumflicker.

This PR changes the default to https:// and because the image is served over https anyway i've removed the https?: boolean parameter instead of swapping the default value.

The only code change is in the imageUrl function( line 93), the other changes are inside comments.

[codecov]

Codecov Report

Merging #1034 (f5410d7) into main (9af77dd) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1034   +/-   ##
=======================================
  Coverage   99.67%   99.67%           
=======================================
  Files        2119     2119           
  Lines      227439   227432    -7     
  Branches      982      982           
=======================================
- Hits       226691   226687    -4     
+ Misses        728      725    -3     
  Partials       20       20           

Impacted Files	Coverage Δ
src/modules/image/index.ts	100.00% <100.00%> (ø)
src/modules/finance/index.ts	100.00% <0.00%> (+0.68%)	⬆️

[ST-DDT]

Should we not consider this a breaking change?

[Shinigami92]

Should we not consider this a breaking change?

IMO it's okay, only very few customers would use this last parameter and even if they would use it, they only get a quick compile error in TS if they even have TS. In JS the last parameter would just be ignored.
I would count it as a minor breaking change, we will highlight it in next release notes at top.