fix(finance.bic): remove hardcoded elements and simplify function

[hankucz]

Fixes #1159

[codecov]

Codecov Report

Merging #1171 (279d378) into main (aafab45) will increase coverage by 0.00%.
The diff coverage is 92.85%.

@@           Coverage Diff           @@
##             main    #1171   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2153     2153           
  Lines      236547   236543    -4     
  Branches      979      979           
=======================================
- Hits       235656   235654    -2     
+ Misses        870      868    -2     
  Partials       21       21           

Impacted Files	Coverage Δ
src/modules/finance/index.ts	99.76% <92.85%> (+0.45%)	⬆️

[ST-DDT]

One regex seems to be failing. Please check the regex for issues.
Is there a validator.js function for that or we could propose it there?

[ST-DDT]

Edit I found this "official" regex: https://stackoverflow.com/a/52043851/4573065
Maybe use somewhere official is source for it?

[hankucz]

Edit I found this "official" regex: https://stackoverflow.com/a/52043851/4573065
Maybe use somewhere official is source for it?

According to https://wise.com/gb/swift-codes/bic-swift-code-checker the location code is 0-9 A-Z. I checked the failed bic YAQHKI1MIMQ and got results:

• Your 4-digit bank code YAQH was not found, but may be correct.
• Your 2-digit country code KI is for Kiribati
• Your 2-digit location code 1M was not found but may be correct.
• Your 3-digit branch code IMQ was not found but may be correct.

Supported by wikipedia https://en.wikipedia.org/wiki/ISO_9362
But then the german version adds some more rules: https://de.wikipedia.org/wiki/ISO_9362

I found the official (demo) standard https://cdn.standards.iteh.ai/samples/84108/21078408ed25469391d0cf6c5d1b6ca9/ISO-9362-2022.pdf and it also does not say anything about those exclusions mentioned on German wiki.

[ST-DDT]

Then use a simple regex. I would even remove the countryCodes from the regex and check them separately (e.g. using substring).

[hankucz]

Rebased and issues fixed. Is it ready to merge?

[hankucz]

The suggested change by @ST-DDT was implemented into the test. Is this ready for merge?