Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locales): add real cities for zu_ZA and af_ZA, update en_ZA city list #2141

Merged
merged 5 commits into from May 9, 2023

Conversation

matthewmayer
Copy link
Contributor

Changes faker.location.city() to use real city names for af_ZA and zu_ZA, like en_ZA

Not all cities have seperate names in all three languages

Originally discussed at #2119 (comment)

@matthewmayer matthewmayer requested a review from a team as a code owner May 8, 2023 09:51
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #2141 (5bc55b1) into next (aab69c9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 5bc55b1 differs from pull request most recent head 1abbde6. Consider uploading reports for the commit 1abbde6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2141      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files        2605     2607       +2     
  Lines      244951   244977      +26     
  Branches     1149     1255     +106     
==========================================
+ Hits       243974   243999      +25     
- Misses        950      951       +1     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/af_ZA/location/city_name.ts 100.00% <100.00%> (ø)
src/locales/af_ZA/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/af_ZA/location/index.ts 100.00% <100.00%> (ø)
src/locales/en_ZA/location/city_name.ts 100.00% <100.00%> (ø)
src/locales/zu_ZA/location/city_name.ts 100.00% <100.00%> (ø)
src/locales/zu_ZA/location/city_pattern.ts 100.00% <100.00%> (ø)
src/locales/zu_ZA/location/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels May 8, 2023
@ST-DDT ST-DDT requested review from a team May 8, 2023 19:41
@ST-DDT ST-DDT enabled auto-merge (squash) May 9, 2023 19:39
@ST-DDT ST-DDT merged commit ee8c97c into faker-js:next May 9, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants