Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(location): add en_IE postcodes #2149

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Conversation

matthewmayer
Copy link
Contributor

https://en.wikipedia.org/wiki/Eircode
https://en.wikipedia.org/wiki/List_of_Eircode_routing_areas_in_Ireland
woocommerce/woocommerce#19745

Note this doesn’t cover all special cases like D6W for the first part, or restricting the letters used in the second part, but should create plausible looking Eircodes

[
  'W91 P896', 'Y66 8VTX',
  'E38 Y0R6', 'E68 VHU5',
  'D68 2P75', 'X95 B234',
  'E42 PSGQ', 'R55 3CB2',
  'D96 8ET8', 'A90 06IS',
  'V58 7L87', 'P31 4RBK',
  'K02 E27E', 'H38 5045',
  'D78 1TLL', 'F62 5TLY',
  'K56 8W89', 'R13 0QX9',
  'D55 97HB', 'X40 AKS2'
]

https://en.wikipedia.org/wiki/Eircode
https://en.wikipedia.org/wiki/List_of_Eircode_routing_areas_in_Ireland
woocommerce/woocommerce#19745

Note this doesn’t cover all special cases like D6W for the first part, or restricting the letters used in the second part, but should create plausible looking Eircodes

```fakerEN_IE.helpers.multiple(()=>fakerEN_IE.location.zipCode(), {count:20})
[
  'W91 P896', 'Y66 8VTX',
  'E38 Y0R6', 'E68 VHU5',
  'D68 2P75', 'X95 B234',
  'E42 PSGQ', 'R55 3CB2',
  'D96 8ET8', 'A90 06IS',
  'V58 7L87', 'P31 4RBK',
  'K02 E27E', 'H38 5045',
  'D78 1TLL', 'F62 5TLY',
  'K56 8W89', 'R13 0QX9',
  'D55 97HB', 'X40 AKS2'
]
```
@matthewmayer matthewmayer requested a review from a team as a code owner May 11, 2023 04:46
@matthewmayer matthewmayer self-assigned this May 11, 2023
@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@e86f3b6). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2149   +/-   ##
=======================================
  Coverage        ?   99.60%           
=======================================
  Files           ?     2632           
  Lines           ?   245581           
  Branches        ?     1158           
=======================================
  Hits            ?   244604           
  Misses          ?      950           
  Partials        ?       27           

@ST-DDT ST-DDT requested review from a team June 17, 2023 11:28
@ST-DDT ST-DDT enabled auto-merge (squash) June 19, 2023 18:47
@ST-DDT ST-DDT merged commit e92c313 into faker-js:next Jun 19, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants