Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add direction to ja #2191

Merged
merged 3 commits into from
Jun 17, 2023

Conversation

KeisukeYamashita
Copy link
Contributor

Hello, I was trying to use Faker to generate dummy directions but I found the ja local is missing.
Therefore, I have added it like

export default [
'North',
'East',
'South',
'West',
'Northeast',
'Northwest',
'Southeast',
'Southwest',
];

Thank you in advance.

Signed-off-by: KeisukeYamashita <19yamashita15@gmail.com>
@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review May 31, 2023 11:17
@KeisukeYamashita KeisukeYamashita requested a review from a team as a code owner May 31, 2023 11:17
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Merging #2191 (df756a0) into next (36d1d3a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2191   +/-   ##
=======================================
  Coverage   99.59%   99.60%           
=======================================
  Files        2621     2622    +1     
  Lines      245476   245479    +3     
  Branches     1151     1153    +2     
=======================================
+ Hits       244483   244505   +22     
+ Misses        966      947   -19     
  Partials       27       27           
Impacted Files Coverage Δ
src/locales/ja/location/direction.ts 100.00% <100.00%> (ø)
src/locales/ja/location/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@matthewmayer matthewmayer added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels May 31, 2023
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@ST-DDT ST-DDT enabled auto-merge (squash) June 17, 2023 05:43
@ST-DDT ST-DDT merged commit 2fa60de into faker-js:next Jun 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants