Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Lastname - Bhadresha, Jangid, Suthar #243

Merged
merged 2 commits into from
Apr 5, 2022
Merged

feat: add Lastname - Bhadresha, Jangid, Suthar #243

merged 2 commits into from
Apr 5, 2022

Conversation

imbdb
Copy link
Contributor

@imbdb imbdb commented Jan 20, 2022

No description provided.

@imbdb imbdb requested a review from a team as a code owner January 20, 2022 12:16
@netlify
Copy link

netlify bot commented Jan 20, 2022 •
edited

✔️ Deploy Preview for vigilant-wescoff-04e480 ready!

🔨 Explore the source changes: 77dfd70

🔍 Inspect the deploy log: https://app.netlify.com/sites/vigilant-wescoff-04e480/deploys/61e952b50a4c3400080baee3

😎 Browse the preview: https://deploy-preview-243--vigilant-wescoff-04e480.netlify.app

@import-brain import-brain added the s: pending triage Pending Triage label Jan 20, 2022
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent and removed s: pending triage Pending Triage labels Jan 20, 2022
@imbdb
Copy link
Contributor Author

imbdb commented Jan 20, 2022

@Shinigami92
I tried running tests on my fork and tests are passing.
Please try running them again.

@ST-DDT
Copy link
Member

ST-DDT commented Jan 20, 2022

FYI: There seems to be a bug with the legacy test framework that causes a single test to fail on windows in the ci between 10 and 20 o'clock UTC (ore something similar strange).
See also #224
The test framework will be replaced in #235 .

@Shinigami92
Copy link
Member

LGTM, but we will merge this in v6.1+

@Shinigami92 Shinigami92 added c: feature Request for new feature c: locale Permutes locale definitions and removed c: feature Request for new feature labels Mar 15, 2022
@Shinigami92 Shinigami92 enabled auto-merge (squash) April 5, 2022 15:39
@Shinigami92 Shinigami92 merged commit 6214425 into faker-js:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prisis prisis prisis approved these changes

@JessicaSachs JessicaSachs JessicaSachs approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@imbdb imbdb

Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
None yet
Milestone
v6.2 - New small features
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@imbdb @ST-DDT @Shinigami92 @prisis @JessicaSachs @import-brain