Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit Card number parameter #181

Open
import-brain opened this issue Jan 16, 2022 · 4 comments · May be fixed by #2720
Open

Credit Card number parameter #181

import-brain opened this issue Jan 16, 2022 · 4 comments · May be fixed by #2720
Assignees
@ST-DDT
Labels
c: docs Improvements or additions to documentation m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Milestone
vAnytime

Comments

@import-brain
Copy link
Member

Screen Shot 2022-01-16 at 2 35 07 PM

In the part of the Finance section of the API docs shown above, I think it would improve the docs if we listed all possible inputs of the 'provider' parameter, such as 'Visa', 'MasterCard', etc. What would happen if someone used gibberish as a parameter there, would an error be thrown?
@import-brain import-brain added c: docs Improvements or additions to documentation c: chore PR that doesn't affect the runtime behavior labels Jan 16, 2022
@clarkerican
Copy link
Contributor

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

@import-brain
Copy link
Member Author

One interesting challenge here is that each locale is going to have different options. We should consider the best way to represent this, cause I think adding the options is likely a good call! But we should probably add the options for each locale.

Yes, we probably need to look at different ways to represent this, because this section taking up half of the page is not optimal.

@Shinigami92 Shinigami92 added this to the v6.1.0 milestone Jan 17, 2022
@ageddesi
Copy link

ageddesi commented Sep 2, 2022 •
edited

What if you provide the options with an expandable section for each local?

@ST-DDT
Copy link
Member

ST-DDT commented Sep 2, 2022

IMO we should describe a way to look these up instead.

@Shinigami92 Shinigami92 removed the c: chore PR that doesn't affect the runtime behavior label Sep 8, 2022
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Sep 8, 2022
@ST-DDT ST-DDT added the m: finance Something is referring to the finance module label Mar 5, 2024
@ST-DDT ST-DDT linked a pull request Mar 5, 2024 that will close this issue
Draft
@ST-DDT ST-DDT self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ST-DDT ST-DDT

Labels
c: docs Improvements or additions to documentation m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Todo
Milestone
vAnytime
Development

Successfully merging a pull request may close this issue.

refactor(finance)!: rewrite creditCardNumber to work with issuer enum faker-js/faker
5 participants
@ageddesi @ST-DDT @Shinigami92 @clarkerican @import-brain